Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search in keywords is failing on compound keywords #2299

Closed
justjam2013 opened this issue Dec 28, 2024 · 4 comments
Closed

Search in keywords is failing on compound keywords #2299

justjam2013 opened this issue Dec 28, 2024 · 4 comments
Labels

Comments

@justjam2013
Copy link
Contributor

Describe The Bug

What is happening?

Search is not properly searching the keywords. A search for "shower head" displays a single plugin:

Screenshot 2024-12-28 at 10 44 40 PM

The homebridge-mqttthing plugin is a partial match, as "shower" is one of the keywords:

Screenshot 2024-12-28 at 10 57 00 PM

The search is not returning the homebridge-virtual-accessories plugin, which has "shower head" in its keywords:

Screenshot 2024-12-28 at 10 57 18 PM

A search for "shower", displays the same results:

Screenshot 2024-12-28 at 11 05 34 PM

Logs

No response

Config

No response

Homebridge UI Version

5.0.0-beta.26

Homebridge Version

1.8.5

Node.js Version

22.12.0

Operating System

macOS

Environment Info

Using hb-service

Raspberry Pi Model

None

@justjam2013 justjam2013 changed the title Search in keywords is not filtering as expected Search in keywords is failing on compound keywords Dec 28, 2024
@justjam2013
Copy link
Contributor Author

justjam2013 commented Dec 28, 2024

A search for "weather station" displays 17 plugins. The homebridge-mqttthing plugin is not one of them.
A search for "weather" displays 7 plugins. The homebridge-mqttthing plugin is not one of them.
A search for "station" displays 4 plugins. The homebridge-mqttthing plugin is not one of them.

Hovever, the homebridge-mqttthing plugin should be a displayed for all three searches, as "weather station" is one of the keywords:

Screenshot 2024-12-28 at 10 57 00 PM copy

It could be argued that the keyword is "weather station", so it should only be displayed for the first search. However, if it was in the the NPM search results, then it should be considered a partial match and not be filtered out.

@bwp91
Copy link
Contributor

bwp91 commented Dec 29, 2024

@justjam2013 line 43 on your keywords is it meant to say blinds and not binds?

@justjam2013
Copy link
Contributor Author

@justjam2013 line 43 on your keywords is it meant to say blinds and not binds?

Nice catch, thank you!

@justjam2013
Copy link
Contributor Author

Tested as working as expected. Closing as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants