Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling terminal access when running in Docker #2303

Open
evanchaney opened this issue Dec 30, 2024 · 1 comment
Open

Disabling terminal access when running in Docker #2303

evanchaney opened this issue Dec 30, 2024 · 1 comment
Labels

Comments

@evanchaney
Copy link

evanchaney commented Dec 30, 2024

Current Situation

When the Homebridge config. UI is installed and running as part of a Homebridge Docker container how can the “Terminal” section of the UI be disabled?

I see in “Turn off Terminal in browser” that there is a HOMEBRIDGE_CONFIG_UI_TERMINAL environment variable. Adding an ENV HOMEBRIDGE_CONFIG_UI_TERMINAL=0 line to the Dockerfile doesn’t seem to work, though.

It looks like maybe the UI is hardcoded to always enable the terminal when running in a Docker container (config source). Is that right?

Is there any way to disable terminal access through the Web UI when running under Docker?

Logs

No response

Config

No response

Homebridge UI Version

4.65.2

Homebridge Version

1.8.5

Node.js Version

22.12.0

Operating System

Raspberry Pi OS / Raspbian

Environment Info

Using Docker

Raspberry Pi Model

None

@bwp91
Copy link
Contributor

bwp91 commented Dec 31, 2024

Hi @evanchaney

Yes at the moment it is hard coded for docker to be enabled, with no way of overriding this.

I’m not sure if there is a real reason for this.

I can publish a beta of the UI to try where it looks for this env variable and disable the terminal if it is present and set to 0.

But i won’t be able to test it myself - and i’m
not sure whether it will lead to any unexpected results.

But i’m definitely happy to publish a beta if you want to try it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants