From 6f9941c46680aa775c5bdbb5baafc1057c0b2c89 Mon Sep 17 00:00:00 2001 From: Northern Man <19808920+NorthernMan54@users.noreply.github.com> Date: Wed, 3 Jan 2024 09:30:57 -0500 Subject: [PATCH] Update to Synology Supplied NodeJS 20 #144 #141 #133 --- .github/workflows/main.yml | 2 +- INFO.sh | 2 +- README.md | 4 ++-- app/source.sh | 5 ++++- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 1117d33..55a0199 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -50,7 +50,7 @@ jobs: #### Dependencies - This package will leverage the Synology supplied NodeJS v18 package. + This package will leverage the Synology supplied NodeJS v20 package. #### Add the Homebridge Synology Package Source: diff --git a/INFO.sh b/INFO.sh index 2b574f8..fdc0346 100755 --- a/INFO.sh +++ b/INFO.sh @@ -17,7 +17,7 @@ silent_upgrade="no" adminprotocol="http" adminurl="" adminport="8581" -install_dep_packages="Node.js_v18" +install_dep_packages="Node.js_v20" displayname="Homebridge" description="Homebridge on Synology DSM." diff --git a/README.md b/README.md index 8457a8d..58d987c 100644 --- a/README.md +++ b/README.md @@ -3,7 +3,7 @@

[![GitHub release](https://img.shields.io/github/release/homebridge/homebridge-syno-spk.svg)](https://github.com/homebridge/homebridge-syno-spk/releases/latest) -[![Build](https://github.com/homebridge/homebridge-syno-spk/workflows/Build/badge.svg)](https://github.com/homebridge/homebridge-syno-spk/actions) +[![Build and Publish](https://github.com/homebridge/homebridge-syno-spk/actions/workflows/main.yml/badge.svg)](https://github.com/homebridge/homebridge-syno-spk/actions/workflows/main.yml) [![Donate](https://badgen.net/badge/donate/paypal/yellow)](https://paypal.me/oznu) # Homebridge Package for Synology DSM @@ -26,7 +26,7 @@ This package will deploy Homebridge and the Homebridge UI natively on your Synol #### Dependencies -This package will leverage the Synology supplied NodeJS v18 package +This package will leverage the Synology supplied NodeJS v20 package #### Add the Homebridge Synology Package Source: diff --git a/app/source.sh b/app/source.sh index cb95424..24413b1 100755 --- a/app/source.sh +++ b/app/source.sh @@ -4,7 +4,10 @@ export HB_SERVICE_STORAGE_PATH="$(readlink -f /var/packages/homebridge/shares/ho NODE_BIN_PATH="/var/packages/homebridge/target/app/bin" # Use Synology supplied NodeJS v18 - https://github.com/homebridge/homebridge-syno-spk/issues/124 -if [ -f /var/packages/Node.js_v18/target/usr/local/bin/node ]; then +if [ -f /var/packages/Node.js_v20/target/usr/local/bin/node ]; then + NODE_BIN_PATH="/var/packages/Node.js_v20/target/usr/local/bin:$NODE_BIN_PATH" + export HB_SERVICE_NODE_EXEC_PATH="/var/packages/Node.js_v20/target/usr/local/bin/node" +elif [ -f /var/packages/Node.js_v18/target/usr/local/bin/node ]; then NODE_BIN_PATH="/var/packages/Node.js_v18/target/usr/local/bin:$NODE_BIN_PATH" export HB_SERVICE_NODE_EXEC_PATH="/var/packages/Node.js_v18/target/usr/local/bin/node" else