fix: getInfo() no longer writes back to second parameter. Use return value. (occurence found by Dmitry)

Author: ralflang

lib/Basic/Vacation.php

@@ -50,7 +50,7 @@ protected function _init()
         /* Perform requested actions. Ingo_Form_Vacation does token checking
          * for us. */
         if ($form->validate($this->vars)) {
-            $form->getInfo($this->vars, $info);
+            $info = $form->getInfo($this->vars, $info);
             $vacation->addresses = $info['addresses'] ?? '';
             $vacation->days = $info['days'];
             $vacation->exclude = $info['excludes'];

lib/Form/Vacation.php

@@ -102,8 +102,8 @@ public function validate($vars = null, $canAutoFill = false)
         }
 
         if ($this->hasFeature('period')) {
-            $this->_start->getInfo($vars, $start);
-            $this->_end->getInfo($vars, $end);
+            $start = $this->_start->getInfo($vars, $start);
+            $end = $this->_end->getInfo($vars, $end);
             if ($start && $end && $end < $start) {
                 $valid = false;
                 $this->_errors['end'] = _("Vacation end date is prior to start.");