From f20fab3c211625634b1999f2ff277211dccd4abc Mon Sep 17 00:00:00 2001 From: Dmitry Petrov Date: Tue, 8 Jul 2025 15:49:43 -0400 Subject: [PATCH 1/2] fix: Do not display empty notification box when saving Vacation form --- lib/Basic/Vacation.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Basic/Vacation.php b/lib/Basic/Vacation.php index ade60cb..eb3bc74 100644 --- a/lib/Basic/Vacation.php +++ b/lib/Basic/Vacation.php @@ -68,7 +68,7 @@ protected function _init() $vacation->disable = true; $notify = _("Rule Disabled"); } else { - $notification->push(_("Changes saved."), 'horde.success'); + $notify = _("Changes saved."); } $ingo_storage->updateRule($vacation); From 40e2f9a67c6c55c5718fb73b05150ebce7145a10 Mon Sep 17 00:00:00 2001 From: Dmitry Petrov Date: Tue, 8 Jul 2025 15:58:01 -0400 Subject: [PATCH 2/2] fix: Do not use undefined variables in getInfo() calls --- lib/Form/Vacation.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Form/Vacation.php b/lib/Form/Vacation.php index adeab40..96d6a5f 100644 --- a/lib/Form/Vacation.php +++ b/lib/Form/Vacation.php @@ -102,8 +102,8 @@ public function validate($vars = null, $canAutoFill = false) } if ($this->hasFeature('period')) { - $start = $this->_start->getInfo($vars, $start); - $end = $this->_end->getInfo($vars, $end); + $start = $this->_start->getInfo($vars, []); + $end = $this->_end->getInfo($vars, []); if ($start && $end && $end < $start) { $valid = false; $this->_errors['end'] = _("Vacation end date is prior to start.");