Minor changes to docs and thread pool

Author: hosseinmoein

docs/HTML/ExponentiallyWeightedMeanVisitor.html

@@ -46,14 +46,14 @@
       <td bgcolor="blue"> <font color="white">
         <PRE><B>
 enum class exponential_decay_spec : unsigned char  {
-    center_of_gravity = 1, // Decay = 1 / (1 + value)   For value >= 0
-    span = 2,              // Decay = 2 / (1 + value)   For value >= 1
-    halflife = 3,          // Decay = 1 - e<sup>log(0.5)/value</sup>   For value > 0
-    fixed = 4,             // Decay = value   For 0 < value <= 1
+    center_of_gravity = 1, // Decay = 1 / (1 + &alpha;)     For &alpha; >= 0
+    span = 2,              // Decay = 2 / (1 + &alpha;)     For &alpha; >= 1
+    halflife = 3,          // Decay = 1 - e<sup>log(0.5)/&alpha; </sup>  For &alpha; > 0
+    fixed = 4,             // Decay = &alpha;               For 0 < &alpha; <= 1
 };</B></PRE></font>
       </td>
       <td>
-        This spec determines how an exponentially moving stat decays. Based on this spec, the value parameter is converted to decay.
+        This spec determines how an exponentially moving stat decays. Based on this spec, the value (&alpha;) parameter is converted to decay.
       </td>
     </tr>
 
@@ -91,17 +91,18 @@
 		</PRE></I>
         Formula if finite_adjust is true:<BR>
 		<I><PRE>
-          X<SUB>t</SUB> + (1 - decay) * X<SUB>t-1</SUB> + (1 - decay)<SUP>2</SUP> * X<SUB>t-2</SUB> + ... + (1 - decay)<SUP>t</SUP> * X<SUB>0</SUB>
-    Y<SUB>t</SUB> = ------------------------------------------------------------------------
-                  1 + (1 - decay) + (1 - decay)<SUP>2</SUP> + ... + (1 - decay)<SUP>t</SUP>
+          X<SUB>t</SUB>+(1-decay)*X<SUB>t-1</SUB>+(1-decay)<SUP>2</SUP>*X<SUB>t-2</SUB>+ ... +(1-decay)<SUP>t</SUP>*X<SUB>0</SUB>
+    Y<SUB>t</SUB> = ------------------------------------------------------
+               1+(1-decay)+(1-decay)<SUP>2</SUP>+ ... +(1-decay)<SUP>t</SUP>
 		</PRE></I>
         Constructor:<BR>
         <I>
         <PRE>
     ExponentiallyWeightedMeanVisitor(
         exponential_decay_spec eds,  // See exponential_decay_spec type
-        double value,                // Value to be decayed
-        bool finite_adjust = false); // Adjust for the fact that this is not an infinite data set
+        double value,                // Value (&alpha;) to be decayed
+        bool finite_adjust = false); // Adjust for the fact that this
+                                     // is not an infinite data set
         </PRE>
         </I>
       </td>
@@ -135,8 +136,8 @@
         <I>
         <PRE>
     ExponentiallyWeightedVarVisitor(
-        exponential_decay_spec eds,  // See exponential_decay_spec type
-        double value);               // Value to be decayed
+        exponential_decay_spec eds, // See exponential_decay_spec type
+        double value);              // Value (&alpha;) to be decayed
         </PRE>
         </I>
       </td>
@@ -170,8 +171,8 @@
         <I>
         <PRE>
     ExponentiallyWeightedCovVisitor(
-        exponential_decay_spec eds,  // See exponential_decay_spec type
-        double value);               // Value to be decayed
+        exponential_decay_spec eds, // See exponential_decay_spec type
+        double value);              // Value (&alpha;) to be decayed
         </PRE>
         </I>
       </td width="30%">
@@ -205,8 +206,8 @@
         <I>
         <PRE>
     ExponentiallyWeightedCorrVisitor(
-        exponential_decay_spec eds,  // See exponential_decay_spec type
-        double value);               // Value to be decayed
+        exponential_decay_spec eds, // See exponential_decay_spec type
+        double value);              // Value (&alpha;) to be decayed
         </PRE>
         </I>
       </td>

include/DataFrame/Utils/Threads/ThreadPool.h

@@ -116,7 +116,7 @@ class   ThreadPool  {
 
     template<std::random_access_iterator I, long TH = 50'000L>
     void parallel_sort(const I begin, const I end);
-    template<std::random_access_iterator I, typename P, long TH = 25'000L>
+    template<std::random_access_iterator I, typename P, long TH = 50'000L>
     void parallel_sort(const I begin, const I end, P compare);
 
     // If the pool is not shutdown and there is a pending task, run the one

include/DataFrame/Utils/Threads/ThreadPool.tcc

@@ -73,7 +73,7 @@ ThreadPool::add_thread(size_type thr_num)  {
         if (shutys > capacity_threads())  {
             char    err[1024];
 
-            ::snprintf(err, 1023,
+            ::snprintf(err, sizeof(err) - 1,
                        "ThreadPool::add_thread(): Cannot subtract "
                        "'%ld' threads from the pool with capacity '%ld'",
                        shutys, capacity_threads());
@@ -167,7 +167,7 @@ ThreadPool::parallel_loop(I begin, I end, F &&routine, As && ... args)  {
         ret.reserve(n);
         for (size_type i = 0; i < n; ++i)
             ret.emplace_back(dispatch(false,
-                                      routine,
+                                      std::forward<F>(routine),
                                           begin + i,
                                           begin + (i + 1),
                                           std::forward<As>(args) ...));
@@ -180,7 +180,7 @@ ThreadPool::parallel_loop(I begin, I end, F &&routine, As && ... args)  {
             };
 
             ret.emplace_back(dispatch(false,
-                                      routine,
+                                      std::forward<F>(routine),
                                           begin + i,
                                           begin + block_end,
                                           std::forward<As>(args) ...));
@@ -220,7 +220,7 @@ ThreadPool::parallel_loop2(I1 begin1, I1 end1, I2 begin2, I2 end2,
         ret.reserve(n);
         for (size_type i = 0; i < n; ++i)
             ret.emplace_back(dispatch(false,
-                                      routine,
+                                      std::forward<F>(routine),
                                           begin1 + i,
                                           begin1 + (i + 1),
                                           begin2 + i,
@@ -234,7 +234,7 @@ ThreadPool::parallel_loop2(I1 begin1, I1 end1, I2 begin2, I2 end2,
             };
 
             ret.emplace_back(dispatch(false,
-                                      routine,
+                                      std::forward<F>(routine),
                                           begin1 + i,
                                           begin1 + block_end,
                                           begin2 + i,