-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button to 'Validate this feature' when clicking a feature on the map #1946
Comments
The problem here is we need the submission instance ID to redirect user to submission instance page (feature detail page). But from the project page, there's no way to access the submission instance id. Is it possible to attach the submission instance ID to the CC: @spwoodcock , @Sujanadh |
Damn, I hoped this would be a simple addition until we do the large validation workflow refactor, but you are completely right! For now, when the user clicks validate now, could we:
The reason I suggest this is that there could be multiple submissions for a feature! |
Doing that wouldn't follow our discussion to validate features by using the next button to validate another feature consequently. Creating another API to list the submission instances along with the entity ID might solve this? |
I think the 'next' based validation would only be on a task level, if the user clicks on a task then 'Validate Task'. On the feature level we wanted to go straight to the submission page, but I realise that's not possible as there may be multiple submissions per feature. Two options:
|
Yeah I was thinking about the first approach too! |
I was thinking about linking What I think would work for us is updating the |
But if a single entity has multiple submissions, it might not work. |
I love the idea! But as you say, the major drawback is if we have multiple submissions. The use case we imagine normally does only have one submission, but we could imagine a mapping campaign for say street level imagery collection, where the user might make multiple submissions for a single POI. If ODK supports it, then we should probably too! |
Plus that's a really tricky thing to do by the sounds of it! I think with any other field we could probably update an entity property on submission, but I imagine the submission uuid is generated on insert into the ODK database, so its not known at the point of submission. Its only after the submission is made it will have an id/uuid, so we may not be able to trigger the entity property update |
Actually, we can access the submission id in the form. Instance id is generated when the form is processed, so we can access it using |
Is your feature request related to a problem? Please describe.
The text was updated successfully, but these errors were encountered: