Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task_Id is passed null on the submission details page #1954

Open
3 tasks done
manjitapandey opened this issue Dec 4, 2024 · 3 comments
Open
3 tasks done

Task_Id is passed null on the submission details page #1954

manjitapandey opened this issue Dec 4, 2024 · 3 comments
Assignees
Labels
backend Related to backend code bug Something isn't working effort:low Likely a few hours frontend Related to frontend code priority:low Backlog of tasks that will be addressed in time testing:ready Ready for testing

Comments

@manjitapandey
Copy link
Contributor

manjitapandey commented Dec 4, 2024

Describe the bug
There is no task id for on submission details page. causing that, we can't filter the data by task_id.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'submission table page'
  2. Click on 'any submission to view project details page'
  3. See the URL 'https://dev.fmtm.hotosm.org/project-submissions/35/tasks/**undefined/**submission/uuid:f649fa99-8f71-410a-98b2-1839c13858a0
  4. See error

Expected behavior

  • The task id should be populated on submission details page URL.
  • User should be able to change the review status
  • The user should be able to filter submissions by task_id.

Screenshots
Image

Additional context
Add any other context about the problem here.

@manjitapandey manjitapandey added the bug Something isn't working label Dec 4, 2024
@NSUWAL123 NSUWAL123 self-assigned this Dec 5, 2024
@NSUWAL123 NSUWAL123 added the testing:ready Ready for testing label Dec 5, 2024
@spwoodcock spwoodcock added priority:low Backlog of tasks that will be addressed in time frontend Related to frontend code effort:low Likely a few hours labels Dec 5, 2024
@manjitapandey
Copy link
Contributor Author

I am still unable to filter the submission by task ID although there are lots of submission on task 4.
Image

@manjitapandey manjitapandey added testing:fail Failed testing and removed testing:ready Ready for testing labels Dec 9, 2024
@NSUWAL123
Copy link
Contributor

There seems to be a bug on the /submission/submission-table after applying the filter.

@manjitapandey when you click the next button (on the bottom) the submissions of task_id = 4.
Image

The Problem:
It seems the filter is being applied to the specific chunks. Let's assume that no filters are applied, and page=1 contains 3 task id of 15, page=2 contains no task id of 15, and page=3 contains 6 task id of 15. So when applying the filter of task=15 on the submissions API, it returns the filtered submissions within the specific range.
https://github.com/user-attachments/assets/006a454f-bc47-4eae-8178-2f0c81372f0d

Solution:
If filtered applied, the pagination should show all the filtered data within the first page, then if the limit exceeds then only proceed to another page

CC: @Sujanadh @Anuj-Gupta4

@NSUWAL123 NSUWAL123 added the backend Related to backend code label Dec 9, 2024
@spwoodcock
Copy link
Member

Thanks for debugging @NSUWAL123! This is great insight 🙏

If @Sujanadh or @Anuj-Gupta4 could look at this at some point, we will include in a patch release (in a week or two) after the mapper frontend release today/tomorrow 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code bug Something isn't working effort:low Likely a few hours frontend Related to frontend code priority:low Backlog of tasks that will be addressed in time testing:ready Ready for testing
Projects
None yet
Development

No branches or pull requests

5 participants