Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new point geom in maplibre terradraw, inject to ODK collect #1966

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

spwoodcock
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Related to #1915

Describe this PR

  • Our current workflow to draw new geoms in ODK is fine.
  • But in order to open up options in the future, I added terradraw to allow creating the point geom in the FMTM map, then open ODK Collect with the new_feature field already filled out.
  • The advantage is that the mapper can see all existing geoms while they draw a new one, including additional geometries that we can load on the map to help facilitate the placement.
  • We can also add polygon or linestring drawing easily.

Screenshots

image

image

image

Will test this on mobile after merge πŸ‘

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock added the frontend Related to frontend code label Dec 9, 2024
@spwoodcock spwoodcock requested a review from NSUWAL123 December 9, 2024 14:06
@spwoodcock spwoodcock self-assigned this Dec 9, 2024
@github-actions github-actions bot added the enhancement New feature or request label Dec 9, 2024
@spwoodcock
Copy link
Member Author

Going to merge this, then test all workflows prior to release.

It's a single commit, so if we discover issues later, it's easy to revert the code in this PR (as use the ODK point drawing instead).

@spwoodcock spwoodcock merged commit 6fdbf96 into development Dec 9, 2024
2 checks passed
@spwoodcock spwoodcock deleted the feat/new-geom-in-fmtm-map branch December 9, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Related to frontend code
Projects
Development

Successfully merging this pull request may close these issues.

1 participant