Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering for Projects to Validate Does Not Function as Desired #6648

Open
Pseudorandom-Pseudonym opened this issue Nov 30, 2024 · 0 comments

Comments

@Pseudorandom-Pseudonym
Copy link

Describe the bug

When filtering for projects to validate, projects with 0 tasks ready for validation still appear on the explore projects page. x>10% of the project cards currently shown when the filter is employed should not be. It appears that the filter is using the "tasks to validate" variable rather than the "ready for validation" variable leading to a significant number of false positive search results. It seems that only projects which are 100% validated and not archived are filtered out. On projects with a greater number of tasks or a low completion % it may not be possibe to tell if a project has tasks ready to validate meaning that manual confirmation is required.

To Reproduce

Steps to reproduce the behavior:
The filter drop down menus to select the filter combinations are to the immidiate left and right of "More filters". This error can be better observed when not logged in as you will see all projects, removing the variable of user permissions.

  1. Go to the HOT TM explore projects page.
  2. Select the filter combination [any project & most vaildated]
  3. On the first page, hover over the progress bar to see 100% validated projects then note the number of pages
  4. Select the filter combination [projects to validate & most vaildated]
  5. On the first page, hover over the progress bar to see the validation % then note the number of pages
  6. Select the filter combination [any project & most mapped]
  7. Note the number of pages of project cards and navigate to the last page.
  8. Select the filter combination [projects to validate & most mapped]
  9. Note the number of pages of project cards and navigate to the last page.
  10. Click on some of the displayed project cards with no indication of project progress or tasks to be validated.
  11. Click on more statistics, then see that when the 'projects to validate' filter is active, projects with 0 tasks to validate are displayed on the explore projects page.

Screenshots
Image
Image
Image
Image
Image
Image
Fig.6. The project progress bar does not always make it possible to see whether there are tasks ready for validation making.

Expected behavior

When the 'projects to validate' filter is active, only those projects which have more than 0 tasks "Ready for validation" should be displayed. This should effectively filter for 'projects to validate' and will also filter out projects who's remaining tasks are all locked (this is important as all projects that are eventually 100% validated will be in this state at some point, and this is not obvious from the explore page). Tasks can be locked for upto 2 hours at a time, so users can find themselves spending time on the project details/contribution page of a project that they are unable to contribute to. Implementing the filter in this way effectively broardens the scope of the task-lock to the explore page. This will lead contributors to projects that they can contribute to, and also address some causes of project stagnation.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Firefox
  • Version 133

Additional context

This error also occurs when using the FastAPI TM test site.

Refering back to the idea of projects being in a state where all available tasks are locked in mind, all projects that are eventually 100% mapped will at some point have all tasks to map locked (perhaps several times). Currently ~ 900 Projects meet the criteria [99%+ mapped & <=99% validated] and are reasonably likely to encounter this state. Could you please also ensure that the 'projects to map' filter is based upon: 0 < (More mapping needed + Available for mapping) rather than the 'Tasks to map' variable. This is significantly more difficult to verify without looking at the source code so I won't be submitting a seperate issue, but I suspect it maybe programmed in a way that doesn't take this state into account, given the behaviour of the 'projects to validate' filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant