Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THR-41: adjust csp rule #608

Closed
wants to merge 8 commits into from
Closed

THR-41: adjust csp rule #608

wants to merge 8 commits into from

Conversation

SteKrause
Copy link
Contributor

@SteKrause SteKrause commented Aug 15, 2023

Description

Adjusted the CSP rules to be able to display the H5P-Editor and Player.

Links to Tickets or other pull requests

Ticket: https://ticketsystem.dbildungscloud.de/browse/THR-41
PR nuxt-client: hpi-schul-cloud/nuxt-client#2736

Changes

Added H5P_SCRIPT_SRC_URL and H5P_IMG_SRC_URL to the config.yml for all instances.

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Screenshots of UI changes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@SteKrause SteKrause requested a review from mamutmk5 September 5, 2023 14:34
@@ -85,6 +85,16 @@ configuration_all:
server: false
client: false
nuxtclient: true
H5P_IMG_SRC_URLS:
value: "https://h5p.org/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not allow by secuery

@SteKrause SteKrause added the is blocked The PR can not be merged because of reasons specified in the PR label Sep 29, 2023
@casparneumann-cap casparneumann-cap deleted the THR-41-adjust-csp-rule branch November 20, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is blocked The PR can not be merged because of reasons specified in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants