-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THR-41: adjust csp rule #608
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
uidp
approved these changes
Sep 4, 2023
mamutmk5
requested changes
Sep 5, 2023
@@ -85,6 +85,16 @@ configuration_all: | |||
server: false | |||
client: false | |||
nuxtclient: true | |||
H5P_IMG_SRC_URLS: | |||
value: "https://h5p.org/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not allow by secuery
SteKrause
added
the
is blocked
The PR can not be merged because of reasons specified in the PR
label
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjusted the CSP rules to be able to display the H5P-Editor and Player.
Links to Tickets or other pull requests
Ticket: https://ticketsystem.dbildungscloud.de/browse/THR-41
PR nuxt-client: hpi-schul-cloud/nuxt-client#2736
Changes
Added H5P_SCRIPT_SRC_URL and H5P_IMG_SRC_URL to the config.yml for all instances.
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Screenshots of UI changes
Approval for review