Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THR-41: adjust csp rule #2736

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

THR-41: adjust csp rule #2736

wants to merge 12 commits into from

Conversation

SteKrause
Copy link
Contributor

@SteKrause SteKrause commented Aug 15, 2023 •
edited
Loading

Short Description

Changed the nginx config to be able to display the H5P-Editor and Player.

Links to Ticket and related Pull-Requests

Ticket: https://ticketsystem.dbildungscloud.de/browse/THR-41
PR dof_app_deploy: hpi-schul-cloud/dof_app_deploy#608

Changes

Adjusted the nginx.conf for the script-src-elem and the img-src.

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@SteKrause SteKrause changed the title Thr 41 adjust csp rule THR-41: adjust csp rule Aug 15, 2023
@SteKrause SteKrause mentioned this pull request Aug 15, 2023
Closed
1 task
@SteKrause SteKrause requested a review from uidp August 15, 2023 06:56
uidp
uidp requested changes Aug 22, 2023
View reviewed changes
dockerconf/nginx.conf.template Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

mamutmk5
mamutmk5 requested changes Sep 5, 2023
View reviewed changes
Dockerfile Show resolved Hide resolved
dockerconf/nginx.conf.template Show resolved Hide resolved
dockerconf/nginx.conf.template Show resolved Hide resolved
@SteKrause SteKrause requested a review from mamutmk5 September 5, 2023 14:31
@SteKrause SteKrause added the is blocked The PR can not be merged because of reasons specified in the PR label Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uidp uidp uidp approved these changes

@mamutmk5 mamutmk5 Awaiting requested review from mamutmk5

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
is blocked The PR can not be merged because of reasons specified in the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SteKrause @mamutmk5 @uidp