Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing folder #43

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Add missing folder #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/schulcloud-server/Coding-Guidelines/modules-submodules.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ import { PublicService, InterfaceOfModule, InterfaceOfSubmodule } from '@modules

Circular dependencies occur when Module A depends on Module B, and Module B also depends on Module A. This can lead to unexpected behavior and hard-to-diagnose bugs.

![Module Structure](./../img/server_area_dependency_v2.svg)
![Module Structure](./../img/server_area_dependency_v3.svg)

Here are some strategies to handle circular dependencies:

Expand Down
21 changes: 0 additions & 21 deletions docs/schulcloud-server/img/server_area_dependency_v2.svg
View file
Open in desktop

This file was deleted.

10 changes: 10 additions & 0 deletions docs/schulcloud-server/img/server_area_dependency_v3.svg
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In einer Migration ist ein Import aus @shared: https://github.com/hpi-schul-cloud/schulcloud-server/blob/main/apps/server/src/migrations/mikro-orm/Migration20240315140224.ts#L5

Ist das ein Import, den wir nicht wollen? Oder willst du noch einen Pfeil zu @shared hinzufügen?

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.