-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove application stats #683
Comments
I think accepted_applications_count is computed on the fly in https://github.com/hpi-schuelerklub/workshop-portal/blob/e3e5cb113ae91fe6e27d943b8e97141f3326b338/app/models/user.rb#L137 rather than being stored somewhere. |
At least the other flag, |
I think So the statistics are only considered evil when they are somewhere stored and not computed on the fly? |
Good question. I doubt that this will be helpful one day, so I'd rather remove all unnecessary code we have. At least the rejected count will never have usable information since we will always delete these fast. |
Remove fields like
accepted_applications_count
and all corresponding logic because we shouldn't save information like thatThe text was updated successfully, but these errors were encountered: