-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: grid / horizontal view ? #268
Comments
Our plan was to begin working on a horizontal collection, and then a grid collection, when we had time. Unfortunately, both @runspired and I joined the Ember core teams and have since run out of time to work on this project 😅 I do want to come back to it when I have time, I just really don't know when that'll be. Happy to help guide new feature work and contributions, feel free to ping me on Discord if you need context/help! |
I will give it a shot soon then. From my digging, my guess on what is needed for a horizontal version is to using Also, I noticed |
I believe it should be documented, that may be a mistake on our part. The docs were the last thing we needed to finish up for the v1 release. Yes, for the most part the idea was that you should be able to sub-out A couple of other things to note:
Let me know if you have any other questions! I'll try to add notes on the code base as I remember things and have time. |
Just the horizontal (new example added to the docs): It works i guess? I didn't bother changing the variable names where I didn't had to :) no tests written but tested with latest chrome, firefox, safari and chrome on android. I will give some thought on the In my particular case, the rows have a fixed height and a variable width for cells (well, they have the same width but that changes on container resize). |
someone went a bit further than me ... :) |
Unfortunately @runspired and I haven't had time to support feature development on this library, and I don't feel comfortable with merging new features with the current state of things. I think the rough plan for this library is:
This will take some time, since we're both busy working on Ember/Ember Data directly. Once we get to step 3 where we can have a more modern codebase, I think we can revisit these features. If anyone would like to get started on the cleanup, I think that would be a great way for us to help get folks up to speed and hand off a lot of the undocumented knowledge of how VC works (in terms of scheduling and hacks around Glimmer). |
@erichonkanen you might get away with some flex-box and a bit of buffer as long as you know how many per row. |
@akondo06 ok good idea, will try thanks! |
@akondo06 any idea what that might look like w/flex? couldn't quite get it using flex, started tinkering w/grid but not clear what that looks like! need to somehow manipulate a flat list of VC items into 3 column grid using only css.. hmm |
@erichonkanen The if that does not suit your needs, you can group the dataset and then render the groups as rows. |
Any chance of getting something similar to
https://bvaughn.github.io/react-virtualized/#/components/Grid ?
Or maybe horizontal scroll support? ( I do realize "vertical" is in the name ;) )
I have tried nesting two collections (100 row by 300 columns) and seems to almost work.
I will probably give it a shot myself in the following weeks, but would like to know if anyone went down that path already.
The text was updated successfully, but these errors were encountered: