Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on data-remove not firing any event on Advanced Select #420

Open
jorgegonzalezpiedra opened this issue Aug 1, 2024 · 1 comment
Open

Comments

@jorgegonzalezpiedra
Copy link

jorgegonzalezpiedra commented Aug 1, 2024

Summary

When clicking the data-remove item "x" in advanced select the change event is not fired.

Steps to Reproduce

  1. Create a advanced select with multiple input
  2. Add a "onChange" event with a console.log showing values
  3. Select a a value, see hoe the console shows the log with the values
  4. Click on the "x" to remove the item, see how the log shows nothing
    screen-capture (1).webm

Demo Link

screen-capture.1.webm

Expected Behavior

When clicking "x" the item is removed

Actual Behavior

When clicking "x" the item is NOT removed

Screenshots

[When clicking "x" the item is removed]screen-capture (1).webm

@oliverhaas
Copy link

I can confirm that removing with the "x" is not firing the change event, since it is removed from the select via javascript, and javascript value updates do not trigger change events by default. However, the Advanced Select should behave like a normal select would imo, so I'm agreeing with you.

Your wording is not ideal however, since the selection actually is removed from the select. So if you submit a form, it works as expected.

A simple workaround is to just add an event listener on click and dispatch a change event yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants