Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EurekaConnection is missing the function in the latest tag 1.3.1 #68

Open
vijaych1209 opened this issue Jun 19, 2018 · 1 comment
Open

Comments

@vijaych1209
Copy link

With go get in my project I am using the eureka connection to look up GetInstancesByVIPAddress.
Its missing in the latest tag pulled by dep though. Should I not be using GetInstancesByVIPAddress. Also Since I couldnt see the loadbalance implementation of returning a single load balanced instance when multiples are registered, I am currently using the shuffle with GetInstancesByVIPAddress.
Is that the correct approach?

@seh
Copy link
Contributor

seh commented Jun 19, 2018

I see (*EurekaConnection).GetInstancesByVIPAddress is still present in file net.go.

As for your second question, I can't figure out what you're asking. Are you wondering whether you need to shuffle the sequence returned by GetInstancesByVIPAddress? You can use the Shuffled and ShuffledWith functions to request that GetInstancesByVIPAddress do the shuffling for you. If you don't shuffle it, you get them in the order sent by the server, which, if I recall correctly, is stable. It's the Eureka client library that does the shuffling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants