fix: mixed_precision param from accelerate config should be used for FSDP mp #3864
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mehant Kammakomati <[email protected]>
SunMarc
reviewed
Dec 1, 2025
| self.parallelism_config is not None and self.parallelism_config.cp_enabled | ||
| ): | ||
| self.distributed_type = DistributedType.FSDP | ||
| self._mixed_precision = mixed_precision |
Member
There was a problem hiding this comment.
this should already be set above, if this changed, can you check why ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For some reason, previous code uses
self._mixed_precisionto set which is not being set before, instead it should be using themixed_precisionparam that is being passed to that function. This would then allow us to use accelerate config'smixed_precisionparam directly to set FSDPv1/v2 MP.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@SunMarc