Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leftover todo from svelte 5 migration #1691

Open
1 of 9 tasks
nsarrazin opened this issue Feb 7, 2025 · 0 comments
Open
1 of 9 tasks

Leftover todo from svelte 5 migration #1691

nsarrazin opened this issue Feb 7, 2025 · 0 comments
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request front This issue is related to the front-end of the app.

Comments

@nsarrazin
Copy link
Collaborator

nsarrazin commented Feb 7, 2025

Migrated the app to Svelte 5 syntax in #1685, seems to have worked well.

I started updating some of the syntax but we still have some leftover use of svelte/legacy in some files:

  • src/lib/components/MobileNav.svelte #1697
  • src/lib/components/ScrollToBottomBtn.svelte
  • src/lib/components/chat/ChatMessage.svelte
  • src/lib/components/chat/ChatWindow.svelte
  • src/lib/components/chat/FileDropzone.svelte
  • src/routes/+layout.svelte
  • src/routes/conversation/[id]/+page.svelte
  • src/routes/tools/+page.svelte
  • src/routes/tools/ToolInputComponent.svelte

Getting rid of it is not super high priority but it would make us more future proof.

We also make use of createEventDispatcher and the $page store which have both been deprecated. Updating these will require a bit more work throughout the app and should be done in small sections if possible so we can thoroughly test the changes.

@nsarrazin nsarrazin added dependencies Pull requests that update a dependency file enhancement New feature or request front This issue is related to the front-end of the app. labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request front This issue is related to the front-end of the app.
Projects
None yet
Development

No branches or pull requests

1 participant