Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not following HF_ENDPOINT environment variable #62

Closed
sandro-qiang opened this issue Jun 30, 2024 · 3 comments
Closed

Not following HF_ENDPOINT environment variable #62

sandro-qiang opened this issue Jun 30, 2024 · 3 comments

Comments

@sandro-qiang
Copy link

sandro-qiang commented Jun 30, 2024

As title said. Some down stream project like text-embeddings-inference affected by this.

@theta-lin
Copy link

You can checkout #47 and #50. There is not much progress yet, unfortunately.

@Narsil
Copy link
Collaborator

Narsil commented Dec 25, 2024

This is not up to this library to add support for every environment variable that might exist in the HF ecosystem.

This library enables overriding or supporting all flags if necessary in downstream apps (if it doesn't, it should).
The truth is that supporting many flags through environment variables introduces bugs, weird/broken behavior that are impossible to sanitize for, simply because we cannot control when those flags are read during an app execution and are often even unknown by the lib users.

This lib enables all the behavior downstream users could want, but we're not going to choose on behalf of them.

By far the most used/demanded feature is proxying for China which is already supported by using HTTP(S)_PROXY environment variables which is down at the reqwest/ureq crates levels. This would superseed the HF_ENDPOINT asked for here most likely.

If your use case isn't solved by HTTP(S)_PROXY please share here more details, which endpoint are you targetting instead and why it isn't possible to use those kind of proxies.

@Narsil
Copy link
Collaborator

Narsil commented Dec 30, 2024

Done through ::from_env method call (which isn't the default on purpose, using environment variables should be opt-in).

#85

@Narsil Narsil closed this as completed Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants