set empty list of suppress tokens to None #36344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @gante for generation config - do you know if this usage of |
|
Hey @Lewington-pitsos 👋 I believe we merged an equivalent fix yesterday: #36336 Let us know whether the underlying issue is fixed with the PR linked above, or whether we need to merge your suggested fix as well 🤗 [@Rocketknight1 yup, |
|
#36336 fixes the issue yes, good stuff guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #36341
pytest /tests/pipelines/ run locally and the same number of tests fail on main as on this branch
this may not be the best way to solve the issue, but it looked like other aspects of the config were being overridden at this point.
Arguably the line
prev_start_of_text = suppress_tokens[-2] if suppress_tokens is not None else Nonewhich is causing the errors should be changed instead though it has been here for > 1 year so I assume the same kind of check exists in a lot of places in the codebase.This new state of affairs is probably more in-line with existing documentation than before as in multiple places the docs state that this parameter should be a list and don't mention anything about overriding with None e.g. https://huggingface.co/docs/transformers/v4.49.0/en/internal/generation_utils#transformers.FlaxSuppressTokensLogitsProcessor
Before submitting
@Rocketknight1 @ylacombe