Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retdec.py has same name as retdec module, causing unhandled exception #9

Closed
Grazfather opened this issue Jun 10, 2018 · 5 comments
Closed

Comments

@Grazfather
Copy link
Collaborator

Repro: Uninstall the retdec-python module, start gdb with extra_plugins_dir set.

What'll happen is retdec will __import__("retdec") which'll import itself, because the plugin path has been added to sys.path. This'll cause a failure because GenericCommand doesn't exist in this context.

@hugsy
Copy link
Owner

hugsy commented Jun 11, 2018

I am aware of this bug. My intention was to totally replace the python-retdec module with the code from https://github.com/hugsy/binja-retdec/blob/master/retdec.py. This way it would work as standalone, and support Python2 (where python-retdec doesn't)... But no time 😢 Feeling up for it @Grazfather ?

@Grazfather
Copy link
Collaborator Author

Probably not :( Super busy until defcon.

@hugsy
Copy link
Owner

hugsy commented Jun 17, 2018

Anyway we shouldn't bother with this plugin anymore, see hugsy/binja-retdec#11
Could be a good opportunity to integrate Hex-Rays decompiler info from IDA instead...

@Grazfather
Copy link
Collaborator Author

We could abandon this, or perhaps add a configuration to point to a specific host, in case the end user is running their own service.

@hugsy
Copy link
Owner

hugsy commented Oct 24, 2018

retdec plugin was removed by 90aa8ad.

Closing.

@hugsy hugsy closed this as completed Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants