Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whole number issue back after update to 3.5.2 #367

Open
deligatedgeek opened this issue Apr 17, 2024 · 8 comments
Open

Whole number issue back after update to 3.5.2 #367

deligatedgeek opened this issue Apr 17, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@deligatedgeek
Copy link

Probably another Solis API "update", but after upgrading to 3.5.2 only whole numbers are showing in home assistant. See the change on the graph below.
Screenshot 2024-04-17 at 10 22 29

Same effect as previous Solis change
Screenshot 2024-04-17 at 10 37 22

Versions
HA Version: Docker 2024.4
HACS version: 1.34.0
Integration version: 3.5.2

@deligatedgeek deligatedgeek added the bug Something isn't working label Apr 17, 2024
@deligatedgeek
Copy link
Author

I think the code should be reverted and the misspelled inveterDetail endpoint should be used. As that endpoint is documented here

@hultenvp
Copy link
Owner

Hi @deligatedgeek,

Picking up again. Is this problem still there or did they fix the resolution in the meantime?
If it's still there then I need to think hard how to proceed as there are some conflicting issues and I do not want to go into cherrypicking data from various endpoints trying to make right what's made wrong by Ginlong Solis.
(see #360 (comment))

@jmccomb1979
Copy link

I think this was 'fixed' by Ginlong Solis, although I've noticed over the past few days, reported battery charging/discharging is back to whole numbers, with the fraction left over getting caught up in the 23:00-00:00 period. This might be due to the Home Assistant 2024.9 update, as graphs before 4th September do not show the whole number jumps..

image
image

@jmccomb1979
Copy link

After running the soliscloud_test.py it seems that the api is returning whole numbers for InverterDetailList. JSON output attached for InverterDetailList and InverterDetail endpoints.
datatest1.json
datatest2.json

@jmccomb1979
Copy link

Have opened a support ticket for the battery charge/discharge whole number issue, and Solis re-enabled the API access that I already had.....

@jmccomb1979
Copy link

I got a reply -

"We have received the reply as the inverter DetailList is calculated by the SC platform, and inverterList is reported by the inverter, so the two values are different, and the R&D staff recommends using inverterDetailList."

I have a fix being tested which pulls only the battery charge/discharge data from inverterList, but the big fiery ball is not visible in the sky today so I'm not seeing any battery activity atm. If it works, I'll submit a PR.

@leroyboerefijn
Copy link

@jmccomb1979 hope you've seen some sunlight since! Any luck fixing this issue? :)

@jmccomb1979
Copy link

@leroyboerefijn Sadly not. My theory was to use only the battery data from the inverterList endpoint, but my python skills were not up to the task. Attempted to re-do the SoloLearn Python Core course that I had completed 6 years ago, but abandoned it when the example code snippets used in their tutorial questions had no indentation. Pointed it out to them and they said "That one isn't supported any more, use the Python Developer course instead". I've not had the time recently to get back to the course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants