Merge pull request #628 from humanmade/backport-617-to-v22-branch

mikelittle · web-flow · commit e4a4d987a138 · 2025-05-27T11:22:16.000+01:00
[Backport v22-branch] Fix warning when no metadata is set for title
diff --git a/inc/class-page.php b/inc/class-page.php
@@ -118,7 +118,7 @@ public function get_subpages() : array {
 			$order_b = $b->get_meta( 'order' ) ?? 0;
 
 			if ( $order_a === $order_b ) {
-				return strnatcasecmp( $a->get_meta( 'title' ), $b->get_meta( 'title' ) );
+				return strnatcasecmp( $a->get_meta( 'title' ) ?? '', $b->get_meta( 'title' ) ?? '' );
 			}
 
 			return $order_a <=> $order_b;

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ public function get_subpages() : array {`
`118`	`118`	`$order_b = $b->get_meta( 'order' ) ?? 0;`
`119`	`119`
`120`	`120`	`if ( $order_a === $order_b ) {`
`121`		`- return strnatcasecmp( $a->get_meta( 'title' ), $b->get_meta( 'title' ) );`
	`121`	`+ return strnatcasecmp( $a->get_meta( 'title' ) ?? '', $b->get_meta( 'title' ) ?? '' );`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`return $order_a <=> $order_b;`