Fix error after deleting a user from system (#344)

Author: yurabakhtin

Events.php

@@ -57,6 +57,11 @@ public static function onIntegrityCheck($event)
                         $messageEntry->delete();
                     }
                 }
+                if(!$messageEntry->message) {
+                    if ($integrityController->showFix("Deleting message entry id " . $messageEntry->id . " without existing conversation!")) {
+                        $messageEntry->delete();
+                    }
+                }
             }
 
             $integrityController->showTestHeadline("Mail Module (" . UserMessage::find()->count() . " user message entries)");

docs/CHANGELOG.md

@@ -1,6 +1,10 @@
 Changelog
 =========
 
+3.0.1  (Unreleased)
+----------------------
+- Fix #343: Fix error after deleting a user from system
+
 3.0.0  (July 26, 2023)
 ----------------------
 - Fix #312: Visibility of scroll down button

models/AbstractMessageEntry.php

@@ -144,13 +144,15 @@ public function afterSave($insert, $changedAttributes)
      */
     public function afterDelete()
     {
-        foreach ($this->message->users as $user) {
-            Yii::$app->live->send(new UserMessageDeleted([
-                'contentContainerId' => $user->contentcontainer_id,
-                'message_id' => $this->message_id,
-                'entry_id' => $this->id,
-                'user_id' => $user->id
-            ]));
+        if ($this->message instanceof Message) {
+            foreach ($this->message->users as $user) {
+                Yii::$app->live->send(new UserMessageDeleted([
+                    'contentContainerId' => $user->contentcontainer_id,
+                    'message_id' => $this->message_id,
+                    'entry_id' => $this->id,
+                    'user_id' => $user->id
+                ]));
+            }
         }
 
         parent::afterDelete();

module.json

@@ -8,7 +8,7 @@
     "messenger",
     "communication"
   ],
-  "version": "3.0.0",
+  "version": "3.0.1",
   "humhub": {
     "minVersion": "1.14"
   },