Attached Files are not removed on Uninstall

[kiwiradler]

Hi,
we have the problem that if you send a private message via the mail module, there are sometimes randomly attached some files from elsewhere in the network. The do not even belong to the people sending the messages. Using Humhub 1.15.2., all modules up do date.
Please investigate asap!

[yurabakhtin]

Hello @kiwiradler, could you please give more details? For example, maybe you can show some sample message text what was sent and what was received in notification.

I have reviewed the code and tested so files are attached to a message entry only if I upload it and on save the content in database has a string like this ![name.jpg](file-guid:6d650fac-5789-41ad-b1df-97928ca2c84d "name.jpg"), also a record must exists in the table file:

[kiwiradler]

Hi,
I don't know if that helps. I marked the files that appeared randomly.

[yurabakhtin]

@kiwiradler Thanks for the images, for me it looks like the messages were created by current User.
Sorry, but now I don't have any idea how they appered there if you didn't create them.

I can only guess if you have installed the module REST API https://marketplace.humhub.com/module/rest/manual and the messages were created by it.

[kiwiradler]

It gets worse. See the attachment to see what happened. My colleague has just written a short message. All the files were attached randomly, without any of them being attached intentionally.

[luke-]

@kiwiradler Can you extract the relevant table records (mail_message table, file table, etc.) from the database and post them here?

[kiwiradler]

Unfortunately it does not stop - even after I have completely uninstalled and reinstalled the mail-module. I'll have a look at the tables now. The others have been deleted with the deinstallation of the module.
This is what happened today...

[kiwiradler]

@kiwiradler Can you extract the relevant table records (mail_message table, file table, etc.) from the database and post them here?

What exactly do you need? If I export the message table, everybody here can read all the messages from our network?! The messages are not encrypted...

[luke-]

You do not have to publish any sensitive information here.

For example, it would be interesting to see the corresponding "files" table entry for an affected file. You can of course remove the file name.

[kiwiradler]

These two files have been attached randomly to a message I wrote. Spooky enough, the files are not shown in the chat, but when I chose "edit", I can see them. I've definitely no clue whats going on there...

[kiwiradler]

Maybe it's important to say that I - once a year - delete the mail module and reinstall it to clear all the chats. The files, that have been written with the mail module, they are not deleted this way? Does it mean, that all the files are still "connected" with the database and are not permanently deleted?

[luke-]

Thanks for the screenshot.

These two files have been attached randomly to a message I wrote. Spooky enough, the files are not shown in the chat, but when I chose "edit", I can see them.

I don't understand, do you only see the files when editing a message? In your previous screenshots, the files were visible in the chat.

[luke-]

Maybe it's important to say that I - once a year - delete the mail module and reinstall it to clear all the chats. The files, that have been written with the mail module, they are not deleted this way? Does it mean, that all the files are still "connected" with the database and are not permanently deleted?

That could be the reason. That the files are not removed when the Mail module is deleted. If a new mail module message with e.g. ID 1 is created, old files become visible again.

You could perform an integrity check. This should recognize and remove old files:

https://docs.humhub.org/docs/admin/troubleshooting#data-integrity

---

@yurabakhtin Can you please check whether the problem is that assigned files are not correctly removed from a message in the Delete module?

[yurabakhtin]

Can you please check whether the problem is that assigned files are not correctly removed from a message in the Delete module?

@luke- I see we deleted only tables of the Messenger module on deactivate/uninstall the module, i.e. these tables are deleted:

• user_message_tag
• message_tag
• user_message
• message_entry
• message

the tables deletion are executed by uninstall migration file /migrations/uninstall.php.
So the records from core table file with object_model = \humhub\modules\mail\models\MessageEntry are not deleted, and after reinstall the module such old records are linked by ID with new created enteries, as you described above.

And yes you are right the integrity check tool solves the issues, I have tested it so all records from the core table file are deleted, but only there is no record \humhub\modules\mail\models\MessageEntry with the ID in database, i.e. the tool can fix only future message entries, it cannot remove files from the existing message entries where files were already linked by such mistake.

I.e. ideally it would be good to run the Integrity Check after reinstall new module.

Also we can add this small code File::deleteAll(['object_model' => MessageEntry::class]); into the protected/modules/mail/migrations/uninstall.php so after uninstall of the Messenger module all old linked files will be deleted. But I think better we should run File->delete(), so maybe we should run the code https://github.com/humhub/humhub/blob/master/protected/humhub/modules/file/Events.php#L69-L74 after disable a Module, do you agree this?

[luke-]

@yurabakhtin Can't we just implement the Module::uninstall() method and call "MessageEntry::delete()" on all of them? It should be executed inside a background job. This should delete all dependencies automatically?

[yurabakhtin]

@luke- PR #381 - I have added to delete all MessageEntry records before disabling of the Messanger module, we have similar code for many other modules.
I don't think we should remove records form other message module tables because all tables are deleted on call the code parent::disable();, and only the MessageEntry may has a linked file.

I have tested on run the code $messageEntry->delete(); all records from the core table file with object_model = \humhub\modules\mail\models\MessageEntry are deleted and also the files are deleted from disk completely.

[kiwiradler]

That sounds good! Unfortunately I have no SSH with my webmaster. Is there another chance to run the integrity check?
Thanks for your help!

[luke-]

Unfortunately not, you could try to clean up the file table manually. However, the files in the uploads directory will then remain.