Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sphinx 2.0 may require a different jQuery body selector #25

Open
humitos opened this issue Aug 9, 2019 · 2 comments
Open

Sphinx 2.0 may require a different jQuery body selector #25

humitos opened this issue Aug 9, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@humitos
Copy link
Owner

humitos commented Aug 9, 2019

I think that Sphinx 2.0 needs this selector:

versionwarning_body_selector = 'div[itemprop="articleBody"]'

while with Sphinx < 2.0 we were using:

versionwarning_body_selector = 'div.body'

So, it would be good to set the proper default based on the Sphinx version.
@humitos humitos added the enhancement New feature or request label Aug 9, 2019
@humitos
Copy link
Owner Author

humitos commented Aug 10, 2019

I think it's not Sphinx 2.0 but the latest release of sphinx-rtd-theme.

@humitos
Copy link
Owner Author

humitos commented Apr 10, 2021

Related to #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@humitos