Skip to content

Commit a780302

Browse files
huntabytehuntabyte
authored
cleanup types and lint issues (#127)
1 parent 8dc80b5 commit a780302

27 files changed

+864
-557
lines changed

‎.changeset/five-coins-change.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"bits-ui": patch
3+
---
4+
5+
- cleanup types and lint issues

‎.eslintignore

+4-1
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,7 @@ package-lock.json
1313
yarn.lock
1414
.changeset/
1515
.prettierrc
16-
package.json
16+
package.json
17+
18+
vite.config.js.timestamp-*
19+
vite.config.ts.timestamp-*

‎.eslintrc.cjs

+24-4
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,42 @@ module.exports = {
33
extends: [
44
"eslint:recommended",
55
"plugin:@typescript-eslint/recommended",
6-
"plugin:svelte/prettier",
6+
"plugin:svelte/recommended",
77
"prettier"
88
],
99
parser: "@typescript-eslint/parser",
1010
plugins: ["@typescript-eslint"],
1111
parserOptions: {
1212
sourceType: "module",
13-
ecmaVersion: 2020,
13+
ecmaVersion: "latest",
1414
extraFileExtensions: [".svelte"]
1515
},
1616
env: {
1717
browser: true,
18-
es2017: true,
18+
es2024: true,
1919
node: true
2020
},
21-
globals: { $$Generic: "readable" },
21+
globals: { $$Generic: "readable", NodeJS: true },
22+
rules: {
23+
"no-console": "warn",
24+
"@typescript-eslint/no-unused-vars": [
25+
"warn",
26+
{
27+
argsIgnorePattern: "^_",
28+
varsIgnorePattern: "^_"
29+
}
30+
],
31+
"svelte/no-target-blank": "error",
32+
"svelte/no-immutable-reactive-statements": "error",
33+
"svelte/prefer-style-directive": "error",
34+
"svelte/no-reactive-literals": "error",
35+
"svelte/no-useless-mustaches": "error",
36+
"svelte/button-has-type": "off",
37+
"svelte/require-each-key": "off",
38+
"svelte/no-at-html-tags": "off",
39+
"svelte/no-unused-svelte-ignore": "off",
40+
"svelte/require-stores-init": "off"
41+
},
2242
overrides: [
2343
{
2444
files: ["*.svelte"],

‎.github/workflows/ci.yml

+82
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,82 @@
1+
name: CI
2+
3+
on:
4+
pull_request:
5+
6+
concurrency:
7+
group: ${{ github.workflow }}-${{ github.event.number || github.sha }}
8+
cancel-in-progress: true
9+
10+
jobs:
11+
check:
12+
name: Run svelte-check
13+
runs-on: ubuntu-latest
14+
steps:
15+
- uses: actions/checkout@v3
16+
with:
17+
fetch-depth: 0
18+
19+
- uses: pnpm/action-setup@v2
20+
with:
21+
version: 8
22+
23+
- uses: actions/setup-node@v3
24+
with:
25+
node-version: 18
26+
27+
# PNPM Store cache setup
28+
- name: Get pnpm store directory
29+
id: pnpm-cache
30+
run: |
31+
echo "pnpm_cache_dir=$(pnpm store path)" >> $GITHUB_OUTPUT
32+
- name: Setup pnpm cache
33+
uses: actions/cache@v3
34+
with:
35+
path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }}
36+
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
37+
restore-keys: |
38+
${{ runner.os }}-pnpm-store-
39+
40+
- name: Install dependencies
41+
run: pnpm install
42+
43+
- name: Run svelte-check
44+
run: pnpm check
45+
46+
lint:
47+
runs-on: ubuntu-latest
48+
name: Lint
49+
steps:
50+
- uses: actions/checkout@v3
51+
with:
52+
fetch-depth: 0
53+
54+
- name: Install Node.JS
55+
uses: actions/setup-node@v3
56+
with:
57+
node-version: 18
58+
59+
- uses: pnpm/action-setup@v2
60+
name: Install pnpm
61+
id: pnpm-install
62+
with:
63+
version: 8
64+
65+
# PNPM Store cache setup
66+
- name: Get pnpm store directory
67+
id: pnpm-cache
68+
run: |
69+
echo "pnpm_cache_dir=$(pnpm store path)" >> $GITHUB_OUTPUT
70+
71+
- name: Setup pnpm cache
72+
uses: actions/cache@v3
73+
with:
74+
path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }}
75+
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
76+
restore-keys: |
77+
${{ runner.os }}-pnpm-store-
78+
79+
- name: Install dependencies
80+
run: pnpm install
81+
82+
- run: pnpm lint

‎.prettierignore

+3
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,6 @@ package.json
1717
.vercel
1818
.contentlayer
1919
dist
20+
21+
vite.config.js.timestamp-*
22+
vite.config.ts.timestamp-*

‎contentlayer.config.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { defineDocumentType, defineNestedType, makeSource } from "contentlayer/source-files";
1+
import { defineDocumentType, makeSource } from "contentlayer/source-files";
22
import path from "path";
33

44
/** @type {import('contentlayer/source-files').ComputedFields} */

‎mdsvex.config.js

+1
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ export function rehypeComponentExample() {
101101
if (!index) return;
102102
parent.children.splice(index + 1, 0, sourceCodeNode);
103103
} catch (e) {
104+
// eslint-disable-next-line no-console
104105
console.error(e);
105106
}
106107
}

‎package.json

+25-25
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"package": "svelte-kit sync && svelte-package && publint",
1414
"prepublishOnly": "pnpm run package",
1515
"test": "pnpm run test:integration && pnpm run test:unit",
16-
"check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json",
16+
"check": "pnpm build:content && svelte-kit sync && svelte-check --tsconfig ./tsconfig.json",
1717
"check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch",
1818
"lint": "prettier --plugin-search-dir . --check . && eslint .",
1919
"format": "prettier --plugin-search-dir . --write .",
@@ -40,51 +40,51 @@
4040
"@playwright/test": "^1.28.1",
4141
"@sveltejs/adapter-auto": "^2.0.0",
4242
"@sveltejs/adapter-vercel": "^3.0.3",
43-
"@sveltejs/kit": "^1.20.4",
44-
"@sveltejs/package": "^2.0.0",
45-
"@tailwindcss/typography": "^0.5.9",
46-
"@typescript-eslint/eslint-plugin": "^5.45.0",
47-
"@typescript-eslint/parser": "^5.45.0",
48-
"autoprefixer": "^10.4.14",
43+
"@sveltejs/kit": "^1.26.0",
44+
"@sveltejs/package": "^2.2.2",
45+
"@tailwindcss/typography": "^0.5.10",
46+
"@typescript-eslint/eslint-plugin": "^6.8.0",
47+
"@typescript-eslint/parser": "^6.8.0",
48+
"autoprefixer": "^10.4.16",
4949
"clsx": "^2.0.0",
50-
"concurrently": "^8.2.0",
50+
"concurrently": "^8.2.2",
5151
"contentlayer": "^0.3.4",
52-
"eslint": "^8.28.0",
52+
"eslint": "^8.52.0",
5353
"eslint-config-prettier": "^8.5.0",
54-
"eslint-plugin-svelte": "^2.30.0",
54+
"eslint-plugin-svelte": "^2.34.0",
5555
"esm-env": "^1.0.0",
5656
"hast-util-to-html": "^9.0.0",
5757
"lucide-svelte": "^0.268.0",
58-
"postcss": "^8.4.24",
58+
"postcss": "^8.4.31",
5959
"postcss-load-config": "^4.0.1",
6060
"prettier": "^2.8.8",
6161
"prettier-plugin-svelte": "^2.10.1",
62-
"publint": "^0.1.9",
62+
"publint": "^0.2.5",
6363
"radix-icons-svelte": "^1.2.1",
6464
"rehype-pretty-code": "^0.10.0",
65-
"remark-gfm": "^3.0.1",
66-
"shiki": "^0.14.3",
67-
"shikiji": "^0.4.0",
68-
"svelte": "^4.0.5",
69-
"svelte-check": "^3.4.3",
65+
"remark-gfm": "^4.0.0",
66+
"shiki": "^0.14.5",
67+
"shikiji": "^0.6.10",
68+
"svelte": "^4.2.2",
69+
"svelte-check": "^3.5.2",
7070
"svelte-sequential-preprocessor": "^2.0.1",
7171
"svelte-wrap-balancer": "^0.0.4",
7272
"tailwind-merge": "^1.14.0",
73-
"tailwind-variants": "^0.1.13",
74-
"tailwindcss": "^3.3.2",
75-
"tailwindcss-animate": "^1.0.6",
76-
"tslib": "^2.4.1",
77-
"typescript": "^5.0.0",
73+
"tailwind-variants": "^0.1.14",
74+
"tailwindcss": "^3.3.3",
75+
"tailwindcss-animate": "^1.0.7",
76+
"tslib": "^2.6.2",
77+
"typescript": "^5.2.2",
7878
"unist-builder": "^4.0.0",
7979
"unist-util-visit": "^5.0.0",
80-
"vite": "^4.4.2",
81-
"vitest": "^0.32.2"
80+
"vite": "^4.5.0",
81+
"vitest": "^0.34.6"
8282
},
8383
"svelte": "./dist/index.js",
8484
"types": "./dist/index.d.ts",
8585
"type": "module",
8686
"dependencies": {
87-
"@melt-ui/svelte": "0.55.2",
87+
"@melt-ui/svelte": "0.55.3",
8888
"nanoid": "^4.0.2"
8989
},
9090
"peerDependencies": {

0 commit comments

Comments
 (0)