You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This raises the question of if we want to drop the namespacing for components that have only a single component within their suite. On one hand, it feels appropriate, and on the other hand, by doing so, we eliminate the ability to introduce other ideas like Option A in the future without a break.
What type of pull request would this be?
New Feature
Provide relevant links or additional information.
No response
The text was updated successfully, but these errors were encountered:
This could work @gurpreetatwal, but I imagine people are creating their own custom checkbox components, so I don't want to misrepresent the fact that they are the same exact thing.
Ah okay, that makes sense. I'd say to go to with option A for consistency unless you're planning on dropping the "namepsace" API in general (e.g. future breaking release may make Checkbox.Root just Checkbox)
Another alternative for option A would be to rename Checkbox.Root to Checkbox.Item (or Checkbox.Box, etc.) but leave Checkbox.Root as a deprecated alias until the next major
We should implement a
CheckboxGroup
component to handle multiple checkbox selections. This component would the state of multipleCheckbox
s.Core Functionality
The
CheckboxGroup
would manage an array of selected values internallyCheckbox.Root
components would automatically integrate with their parent CheckboxGroupAPI Options
Option A
This feels a bit weird because the
Group
would end up wrapping the root if we added it to theCheckbox
namespace:Option B
Be the first component to violate the name-space API:
This raises the question of if we want to drop the namespacing for components that have only a single component within their suite. On one hand, it feels appropriate, and on the other hand, by doing so, we eliminate the ability to introduce other ideas like Option A in the future without a break.
What type of pull request would this be?
New Feature
Provide relevant links or additional information.
No response
The text was updated successfully, but these errors were encountered: