-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Charts #1175
Comments
I'm in contact with @techniq about how we can integrate It appears this issue will get us most of the way there: |
UP UP UP Lets do it |
Btw, using LayerChart with shadcn-svelte is already possible. See the integration issue (which will make it to the docs soon) as well as a simple example project. Mostly the integration is just mapping tailwind design tokens/colors ( Simplified Chart components is to simplify common use cases like AreaChart, BarChart, etc, but you can always leverage the full components and chart types within LayerChart (start with Not sure when I'll get started on the effort, but I have a good idea of the approach and shouldn't take long, and we can continue to iterate. |
@techniq @huntabyte we want the templates that shadcn have on their page, they make the whole process 100x easier |
@0x090909 speaking for @huntabyte, but the docs integration will be coming. Mostly exposing the same examples in LayerChart but with shadcn-svelte copy/paste. |
Lets go, i will integrate with my app🙌 |
LFG!!! |
I just want to give love ❤️ |
any update with this ?? |
updates? |
is there any possibility these charts will be realease in the near future? or we should use another chart library ? let us know |
updates?= |
Update: Sorry work/life has been rather busy (and not slowing down). I also just returned from a family vacation today, but I hope to resume work on the Simplified Charts PR this week 🤞. While the end goal is to have copy/paste support for common chart types (Bar, Line, Area, etc) on the shadcn-svelte docs, 80% of this is already available with slightly longer form
export default {
content: [
"./src/**/*.{html,js,svelte,ts}",
"./node_modules/layerchart/**/*.{svelte,js}"
],
theme: {
extend: {
colors: {
surface: {
content: "hsl(var(--card-foreground) / <alpha-value>)",
100: "hsl(var(--background) / <alpha-value>)",
200: "hsl(var(---muted) / <alpha-value>)",
// not sure what color maps here (should be darker than 200). Could add a new color to `app.css`
300: "hsl(var(--background) / <alpha-value>)"
}
}
},
},
};
I don't have a deadline for when the simplified charts PR and subsequent shadcn-svelte docs integration will be complete but it's at the top of my priority queue ATM. I work on open source mostly in the evenings as work and family schedule allows, but hopefully it won't be much longer. I also suggest monitoring the Simplified Charts PR for progress. Have a great day! |
@techniq you're an absolute machine. Thanks for working on this and keeping us updated |
So awesome! Thank you all |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@0x090909 just read 4 comments before yours. |
This comment has been minimized.
This comment has been minimized.
Quick update: I've been very busy cranking away on the new Simplified Charts, refined Tooltips, extracting a new suite of packages ( So far I've created simplified charts for There are more use cases for these simplified components I want to think through and support, update more of the existing examples to these components (but trying to find the right balance as well), and add more of these chart types (PieChart, stack chart, radial charts, etc). See some of my thoughts in the original issue. The goal of the simplified charts is "streamlined opinionated base chart components with full extension capability" so anything you could have created with Some of the stack/group examples might have to wait until more Chart improvements are integrated (see also LayerCake's derivedScales PR). You can 100% create stacked, grouped, stacked and grouped, multi series, diverging, etc charts now (see all the existing examples), but I want to simplify both the implementation and the usage. I'm contemplating updating LayerChart's My work has been pretty crazy lately, and it's also soccer season so I'm always running one of my 3 kids to practices or games this time of year, but anytime I'm near my laptop I'm usually working on this (or thinking about it while exercising) 😁 In short, I'm very actively working on this, and good things will come to those who wait, but don't forget you don't need to wait on these, and migration will basically be changing Thanks for your patience 🫶 |
nice!!!! layercharts! |
@techniq thanks for the update! Take your time, spend time with your kids. The community really appreciates all the work, we are happy to wait since it'll definitely be worth it in the end. |
CleanShot.2024-09-23.at.09.07.05.2.mp4We are live!!! I wrote up an overview of the massive 0.50.0 release on Twitter/X and would appreciate any social love (likes, reposts, etc) to increase reach. I also submitted a talk proposal "What's new with LayerChart" for the fall Svelte Summit conference, and hopefully it gets accepted. |
@techniq properly incredible stuff! Definitely implementing some of this right away! 🙌 |
@huntabyte is this going to be rolled up into the shadcn-svelte chart component? |
One of the problems I see with adding packages like this is that they use stores instead of runes. These packages get almost too complex to rewrite with It seems that svelte shad-cn is striving to be rune-only, so IMO spending time adding an outdated package (until it uses runes) would be counter productive. I personally would like all svelte-shadcn packages to be compatible with rune mode: export default {
compilerOptions: {
runes: true
}
}; I'm wondering why the charts was removed from @next? J |
I'd prefer, personally, just a port of shadcn chart to shadcn-svelte. |
@jdgamble555 Don't worry, LayerChart (and Svelte UX) will be migrated to Svelte 5 (runes, snippets) soon... @burggraf shadcn/ui charts use Recharts to provide the chart component foundation (which is React only), and is what LayerChart is providing for Svelte. This is similar in nature to shadcn/ui using radix-ui and shadcn-svelte using bits-ui (albeit bits-ui is also written by @huntabyte because he's awesome like that). LayerChart also provides a broader range of visualization components compared to Recharts (cartesian/polar only), such as hierarchy, graph, force, and geo. I've been supporting @huntabyte and @shyakadavis as they work on the shadcn-svelte integration / docs to make sure LayerChart has all the needed capability, but don't have the bandwidth to do much of this work myself (transitioning jobs this/next week and going hard on Svelte 5 migration soon). We'll get this one over the finish line, but remember there is already integration with shadcn-svelte theming with LayerChart that many are already using. |
Describe the feature
Just recently, Shacdn official has launched Charts : https://ui.shadcn.com/docs/components/chart
I was thinking we can keep this issue open to track when this'll be implemented. I'm not sure about the way the components are translated from Shacdn official to Svelte. Let me know if I can help.
The text was updated successfully, but these errors were encountered: