Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkbox docs improvement #1170

Closed
manicar2093 opened this issue Jul 3, 2024 · 5 comments · May be fixed by #1266
Closed

Checkbox docs improvement #1170

manicar2093 opened this issue Jul 3, 2024 · 5 comments · May be fixed by #1266
Assignees
@manicar2093
Labels
type: documentation A change or addition to the documentation

Comments

@manicar2093
Copy link

Change Type

Addition

Proposed Changes

Hi!

I had a problem with this Checkbox component. The issue #948 helped me, but I was wondering if there is the chance to add this explicitly in docs

I know, I should've seen it reading the implementation, but why not be explicit showing the solution? 😃

By the way, thanks for your awesome work!!! you are amaizing
@manicar2093 manicar2093 added the type: documentation A change or addition to the documentation label Jul 3, 2024
@huntabyte
Copy link
Owner

huntabyte commented Jul 3, 2024 •
edited
Loading

Absolutely! Thank you! Is this something you want to tackle?

@manicar2093
Copy link
Author

Absolutely! Thank you! Is this something you want to tackle?

Sure! I can do it! 😃

@manicar2093
Copy link
Author

@huntabyte could you assign me this issue? 😃 I just saw how to contribute and I'm ready 😃

@manicar2093 manicar2093 mentioned this issue Jul 9, 2024
Closed
@manicar2093
Copy link
Author

Hi! I've created the PR! I hope is well done!

@manicar2093 manicar2093 mentioned this issue Sep 10, 2024
Open
@huntabyte
Copy link
Owner

This is no longer necessary in shadcn-svelte@next! Just adding the name prop is sufficient to handle the rendering of a hidden input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manicar2093 manicar2093

Labels
type: documentation A change or addition to the documentation
Projects
None yet
Milestone
No milestone
2 participants
@manicar2093 @huntabyte