Better output

Author: caendesilva

src/check-site-url.sh

@@ -19,16 +19,19 @@ check_site_url() {
     # If config/hyde.php exists, check if it has a non-localhost URL
     if [ -f "config/hyde.php" ]; then
         # Look for url configuration line and exclude localhost
-        if grep -q "'url' => env('SITE_URL'," config/hyde.php && \
-           ! grep -q "'url' => env('SITE_URL', 'http://localhost')," config/hyde.php; then
-            return 0
+        if grep -q "'url' => env('SITE_URL'," config/hyde.php; then
+            line_number=$(grep -n "'url' => env('SITE_URL'," config/hyde.php | cut -d: -f1)
+            if ! grep -q "'url' => env('SITE_URL', 'http://localhost')," config/hyde.php; then
+                return 0
+            fi
+            echo "::warning file=config/hyde.php,line=$line_number,title=Missing Site URL::The site URL is set to localhost in your configuration file. Consider setting a production URL."
+            return 1
         fi
     fi
 
+    echo "::warning title=Missing Site URL::No SITE_URL environment variable found. It's recommended to set a production URL for your site. You can set it using the 'env' input with 'SITE_URL=https://example.com'"
     return 1
 }
 
 # Show warning if SITE_URL is not properly set
-if ! check_site_url; then
-    echo "::warning::No SITE_URL environment variable found. It's recommended to set a production URL for your site. You can set it using the 'env' input with 'SITE_URL=https://example.com'"
-fi
+check_site_url

tests/unit/test-check-site-url.sh

@@ -8,7 +8,7 @@ test_site_url_warnings() {
     # Test case 1: No SITE_URL set anywhere
     touch .env
     output=$(bash "$base_dir/src/check-site-url.sh")
-    expected="::warning::No SITE_URL environment variable found. It's recommended to set a production URL for your site. You can set it using the 'env' input with 'SITE_URL=https://example.com'"
+    expected="::warning title=Missing Site URL::No SITE_URL environment variable found. It's recommended to set a production URL for your site. You can set it using the 'env' input with 'SITE_URL=https://example.com'"
 
     if [[ "$output" != "$expected" ]]; then
         echo "Test 1 failed: Warning not shown when SITE_URL is missing"
@@ -50,6 +50,7 @@ test_site_url_warnings() {
     # Test case 4: SITE_URL in config but with localhost
     echo "'url' => env('SITE_URL', 'http://localhost')," > config/hyde.php
     output=$(bash "$base_dir/src/check-site-url.sh")
+    expected="::warning file=config/hyde.php,line=1,title=Missing Site URL::The site URL is set to localhost in your configuration file. Consider setting a production URL."
 
     if [[ "$output" != "$expected" ]]; then
         echo "Test 4 failed: Warning not shown when SITE_URL is localhost"