Skip to content

Commit 260c51f

Browse files
Ensure constructor header dict mutations do not leak
Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>
1 parent 4286978 commit 260c51f

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

tests/test_custom_headers.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,9 @@ def test_sync_client_config_headers_are_applied_to_transport():
4848

4949

5050
def test_sync_client_constructor_headers_are_applied_to_transport():
51-
client = Hyperbrowser(api_key="test-key", headers={"X-Team-Trace": "team-2"})
51+
headers = {"X-Team-Trace": "team-2"}
52+
client = Hyperbrowser(api_key="test-key", headers=headers)
53+
headers["X-Team-Trace"] = "mutated"
5254
try:
5355
assert client.transport.client.headers["X-Team-Trace"] == "team-2"
5456
finally:
@@ -70,7 +72,9 @@ async def run() -> None:
7072

7173
def test_async_client_constructor_headers_are_applied_to_transport():
7274
async def run() -> None:
73-
client = AsyncHyperbrowser(api_key="test-key", headers={"X-Team-Trace": "team-2"})
75+
headers = {"X-Team-Trace": "team-2"}
76+
client = AsyncHyperbrowser(api_key="test-key", headers=headers)
77+
headers["X-Team-Trace"] = "mutated"
7478
try:
7579
assert client.transport.client.headers["X-Team-Trace"] == "team-2"
7680
finally:

0 commit comments

Comments
 (0)