Require upload and extension paths to reference files

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/extension.py

@@ -17,6 +17,10 @@ async def create(self, params: CreateExtensionParams) -> ExtensionResponse:
         # Check if file exists before trying to open it
         if not os.path.exists(file_path):
             raise HyperbrowserError(f"Extension file not found at path: {file_path}")
+        if not os.path.isfile(file_path):
+            raise HyperbrowserError(
+                f"Extension file path must point to a file: {file_path}"
+            )
 
         try:
             with open(file_path, "rb") as extension_file:

hyperbrowser/client/managers/async_manager/session.py

@@ -115,6 +115,12 @@ async def upload_file(
     ) -> UploadFileResponse:
         if isinstance(file_input, (str, PathLike)):
             file_path = os.fspath(file_input)
+            if not os.path.exists(file_path):
+                raise HyperbrowserError(f"Upload file not found at path: {file_path}")
+            if not os.path.isfile(file_path):
+                raise HyperbrowserError(
+                    f"Upload file path must point to a file: {file_path}"
+                )
             try:
                 with open(file_path, "rb") as file_obj:
                     files = {"file": file_obj}

hyperbrowser/client/managers/sync_manager/extension.py

@@ -17,6 +17,10 @@ def create(self, params: CreateExtensionParams) -> ExtensionResponse:
         # Check if file exists before trying to open it
         if not os.path.exists(file_path):
             raise HyperbrowserError(f"Extension file not found at path: {file_path}")
+        if not os.path.isfile(file_path):
+            raise HyperbrowserError(
+                f"Extension file path must point to a file: {file_path}"
+            )
 
         try:
             with open(file_path, "rb") as extension_file:

hyperbrowser/client/managers/sync_manager/session.py

@@ -107,6 +107,12 @@ def upload_file(
     ) -> UploadFileResponse:
         if isinstance(file_input, (str, PathLike)):
             file_path = os.fspath(file_input)
+            if not os.path.exists(file_path):
+                raise HyperbrowserError(f"Upload file not found at path: {file_path}")
+            if not os.path.isfile(file_path):
+                raise HyperbrowserError(
+                    f"Upload file path must point to a file: {file_path}"
+                )
             try:
                 with open(file_path, "rb") as file_obj:
                     files = {"file": file_obj}

tests/test_extension_manager.py

@@ -129,3 +129,24 @@ async def run():
             await manager.create(params)
 
     asyncio.run(run())
+
+
+def test_sync_extension_create_rejects_directory_path(tmp_path):
+    transport = _SyncTransport()
+    manager = SyncExtensionManager(_FakeClient(transport))
+    params = CreateExtensionParams(name="dir-extension", file_path=tmp_path)
+
+    with pytest.raises(HyperbrowserError, match="must point to a file"):
+        manager.create(params)
+
+
+def test_async_extension_create_rejects_directory_path(tmp_path):
+    transport = _AsyncTransport()
+    manager = AsyncExtensionManager(_FakeClient(transport))
+    params = CreateExtensionParams(name="dir-extension", file_path=tmp_path)
+
+    async def run():
+        with pytest.raises(HyperbrowserError, match="must point to a file"):
+            await manager.create(params)
+
+    asyncio.run(run())

tests/test_session_upload_file.py

@@ -163,7 +163,7 @@ def test_sync_session_upload_file_raises_hyperbrowser_error_for_missing_path(tmp
     manager = SyncSessionManager(_FakeClient(_SyncTransport()))
     missing_path = tmp_path / "missing-file.txt"
 
-    with pytest.raises(HyperbrowserError, match="Failed to open upload file"):
+    with pytest.raises(HyperbrowserError, match="Upload file not found"):
         manager.upload_file("session_123", missing_path)
 
 
@@ -172,7 +172,24 @@ def test_async_session_upload_file_raises_hyperbrowser_error_for_missing_path(tm
     missing_path = tmp_path / "missing-file.txt"
 
     async def run():
-        with pytest.raises(HyperbrowserError, match="Failed to open upload file"):
+        with pytest.raises(HyperbrowserError, match="Upload file not found"):
             await manager.upload_file("session_123", missing_path)
 
     asyncio.run(run())
+
+
+def test_sync_session_upload_file_rejects_directory_path(tmp_path):
+    manager = SyncSessionManager(_FakeClient(_SyncTransport()))
+
+    with pytest.raises(HyperbrowserError, match="must point to a file"):
+        manager.upload_file("session_123", tmp_path)
+
+
+def test_async_session_upload_file_rejects_directory_path(tmp_path):
+    manager = AsyncSessionManager(_FakeClient(_AsyncTransport()))
+
+    async def run():
+        with pytest.raises(HyperbrowserError, match="must point to a file"):
+            await manager.upload_file("session_123", tmp_path)
+
+    asyncio.run(run())