Test metadata prefix control-char sanitization paths

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

tests/test_extension_create_utils.py

@@ -209,6 +209,29 @@ def test_normalize_extension_create_input_uses_default_not_file_prefix_when_meta
     assert exc_info.value.original_error is None
 
 
+def test_normalize_extension_create_input_sanitizes_control_chars_in_metadata_missing_prefix(
+    tmp_path, monkeypatch: pytest.MonkeyPatch
+):
+    missing_path = tmp_path / "missing-extension.zip"
+    params = CreateExtensionParams(name="missing-extension", file_path=missing_path)
+    monkeypatch.setattr(
+        extension_create_utils,
+        "EXTENSION_OPERATION_METADATA",
+        SimpleNamespace(
+            missing_file_message_prefix="Custom\tmissing prefix",
+            not_file_message_prefix="Custom extension not-file prefix",
+        ),
+    )
+
+    with pytest.raises(
+        HyperbrowserError,
+        match="Custom\\?missing prefix:",
+    ) as exc_info:
+        normalize_extension_create_input(params)
+
+    assert exc_info.value.original_error is None
+
+
 def test_normalize_extension_create_input_rejects_control_character_path():
     params = CreateExtensionParams(
         name="bad-extension",

tests/test_extension_manager.py

@@ -254,6 +254,50 @@ def _open_binary_file_stub(file_path, *, open_error_message):  # type: ignore[no
     )
 
 
+def test_sync_extension_create_sanitizes_control_chars_in_metadata_open_prefix(
+    monkeypatch: pytest.MonkeyPatch,
+):
+    manager = SyncExtensionManager(_FakeClient(_SyncTransport()))
+    manager._OPERATION_METADATA = type(
+        "_Metadata",
+        (),
+        {
+            "create_operation_name": "create extension",
+            "open_file_error_prefix": "Custom\textension open",
+        },
+    )()
+    params = CreateExtensionParams(name="my-extension", file_path="/tmp/ignored.zip")
+    captured: dict[str, str] = {}
+
+    @contextmanager
+    def _open_binary_file_stub(file_path, *, open_error_message):  # type: ignore[no-untyped-def]
+        captured["file_path"] = file_path
+        captured["open_error_message"] = open_error_message
+        yield io.BytesIO(b"content")
+
+    monkeypatch.setattr(
+        sync_extension_module,
+        "normalize_extension_create_input",
+        lambda _: ("bad\tpath.zip", {"name": "my-extension"}),
+    )
+    monkeypatch.setattr(
+        sync_extension_module,
+        "open_binary_file",
+        _open_binary_file_stub,
+    )
+    monkeypatch.setattr(
+        sync_extension_module,
+        "create_extension_resource",
+        lambda **kwargs: SimpleNamespace(id="ext_sync_mock"),
+    )
+
+    response = manager.create(params)
+
+    assert response.id == "ext_sync_mock"
+    assert captured["file_path"] == "bad\tpath.zip"
+    assert captured["open_error_message"] == "Custom?extension open: bad?path.zip"
+
+
 def test_async_extension_create_does_not_mutate_params_and_closes_file(tmp_path):
     transport = _AsyncTransport()
     manager = AsyncExtensionManager(_FakeClient(transport))
@@ -424,6 +468,57 @@ async def run():
     )
 
 
+def test_async_extension_create_sanitizes_control_chars_in_metadata_open_prefix(
+    monkeypatch: pytest.MonkeyPatch,
+):
+    manager = AsyncExtensionManager(_FakeClient(_AsyncTransport()))
+    manager._OPERATION_METADATA = type(
+        "_Metadata",
+        (),
+        {
+            "create_operation_name": "create extension",
+            "open_file_error_prefix": "Custom\textension open",
+        },
+    )()
+    params = CreateExtensionParams(name="my-extension", file_path="/tmp/ignored.zip")
+    captured: dict[str, str] = {}
+
+    @contextmanager
+    def _open_binary_file_stub(file_path, *, open_error_message):  # type: ignore[no-untyped-def]
+        captured["file_path"] = file_path
+        captured["open_error_message"] = open_error_message
+        yield io.BytesIO(b"content")
+
+    async def _create_extension_resource_async_stub(**kwargs):
+        _ = kwargs
+        return SimpleNamespace(id="ext_async_mock")
+
+    monkeypatch.setattr(
+        async_extension_module,
+        "normalize_extension_create_input",
+        lambda _: ("bad\tpath.zip", {"name": "my-extension"}),
+    )
+    monkeypatch.setattr(
+        async_extension_module,
+        "open_binary_file",
+        _open_binary_file_stub,
+    )
+    monkeypatch.setattr(
+        async_extension_module,
+        "create_extension_resource_async",
+        _create_extension_resource_async_stub,
+    )
+
+    async def run():
+        return await manager.create(params)
+
+    response = asyncio.run(run())
+
+    assert response.id == "ext_async_mock"
+    assert captured["file_path"] == "bad\tpath.zip"
+    assert captured["open_error_message"] == "Custom?extension open: bad?path.zip"
+
+
 def test_sync_extension_create_raises_hyperbrowser_error_when_file_missing(tmp_path):
     transport = _SyncTransport()
     manager = SyncExtensionManager(_FakeClient(transport))

tests/test_session_upload_utils.py

@@ -346,6 +346,48 @@ def _open_binary_file_stub(file_path, *, open_error_message):  # type: ignore[no
     assert captured["open_error_message"] == "Failed to open upload file at path: bad?path.txt"
 
 
+def test_open_upload_files_from_input_sanitizes_control_chars_in_metadata_open_prefix(
+    monkeypatch: pytest.MonkeyPatch,
+):
+    captured: dict[str, str] = {}
+
+    @contextmanager
+    def _open_binary_file_stub(file_path, *, open_error_message):  # type: ignore[no-untyped-def]
+        captured["file_path"] = file_path
+        captured["open_error_message"] = open_error_message
+        yield io.BytesIO(b"content")
+
+    monkeypatch.setattr(
+        session_upload_utils,
+        "normalize_upload_file_input",
+        lambda file_input: ("bad\tpath.txt", None),
+    )
+    monkeypatch.setattr(
+        session_upload_utils,
+        "SESSION_OPERATION_METADATA",
+        type(
+            "_Metadata",
+            (),
+            {
+                "upload_missing_file_message_prefix": "Custom missing prefix",
+                "upload_not_file_message_prefix": "Custom not-file prefix",
+                "upload_open_file_error_prefix": "Custom\topen",
+            },
+        )(),
+    )
+    monkeypatch.setattr(
+        session_upload_utils,
+        "open_binary_file",
+        _open_binary_file_stub,
+    )
+
+    with open_upload_files_from_input("ignored-input") as files:
+        assert files["file"].read() == b"content"
+
+    assert captured["file_path"] == "bad\tpath.txt"
+    assert captured["open_error_message"] == "Custom?open: bad?path.txt"
+
+
 def test_open_upload_files_from_input_rejects_missing_normalized_file_object(
     monkeypatch: pytest.MonkeyPatch,
 ):