Validate non-negative client timeout configuration

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/async_client.py

@@ -1,5 +1,6 @@
 from typing import Mapping, Optional
 
+from ..exceptions import HyperbrowserError
 from ..config import ClientConfig
 from ..transport.async_transport import AsyncTransport
 from .base import HyperbrowserBase
@@ -24,8 +25,10 @@ def __init__(
         api_key: Optional[str] = None,
         base_url: Optional[str] = None,
         headers: Optional[Mapping[str, str]] = None,
-        timeout: Optional[int] = 30,
+        timeout: Optional[float] = 30,
     ):
+        if timeout is not None and timeout < 0:
+            raise HyperbrowserError("timeout must be non-negative")
         super().__init__(AsyncTransport, config, api_key, base_url, headers)
         self.transport.client.timeout = timeout
         self.sessions = SessionManager(self)

hyperbrowser/client/sync.py

@@ -1,5 +1,6 @@
 from typing import Mapping, Optional
 
+from ..exceptions import HyperbrowserError
 from ..config import ClientConfig
 from ..transport.sync import SyncTransport
 from .base import HyperbrowserBase
@@ -24,8 +25,10 @@ def __init__(
         api_key: Optional[str] = None,
         base_url: Optional[str] = None,
         headers: Optional[Mapping[str, str]] = None,
-        timeout: Optional[int] = 30,
+        timeout: Optional[float] = 30,
     ):
+        if timeout is not None and timeout < 0:
+            raise HyperbrowserError("timeout must be non-negative")
         super().__init__(SyncTransport, config, api_key, base_url, headers)
         self.transport.client.timeout = timeout
         self.sessions = SessionManager(self)

tests/test_client_timeout.py

@@ -0,0 +1,29 @@
+import asyncio
+
+import pytest
+
+from hyperbrowser import AsyncHyperbrowser, Hyperbrowser
+from hyperbrowser.exceptions import HyperbrowserError
+
+
+def test_sync_client_rejects_negative_timeout():
+    with pytest.raises(HyperbrowserError, match="timeout must be non-negative"):
+        Hyperbrowser(api_key="test-key", timeout=-1)
+
+
+def test_async_client_rejects_negative_timeout():
+    with pytest.raises(HyperbrowserError, match="timeout must be non-negative"):
+        AsyncHyperbrowser(api_key="test-key", timeout=-1)
+
+
+def test_sync_client_accepts_none_timeout():
+    client = Hyperbrowser(api_key="test-key", timeout=None)
+    client.close()
+
+
+def test_async_client_accepts_none_timeout():
+    async def run() -> None:
+        client = AsyncHyperbrowser(api_key="test-key", timeout=None)
+        await client.close()
+
+    asyncio.run(run())