Feature/order invalidation cronjob #266
Conversation
this errors was not caught due to ts-expect-error directive
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Jipperism
force-pushed
the
feature/order-invalidation-cronjob
branch
from
1d7c4b7 to
df06f74
Compare
Jipperism
force-pushed
the
feature/order-invalidation-cronjob
branch
from
df06f74 to
7172707
Compare
Introduces a new cronjob to periodically validate and potentially invalidate marketplace orders. The cronjob checks all valid orders, and certain invalid orders with specific error codes.
Jipperism
force-pushed
the
feature/order-invalidation-cronjob
branch
from
7172707 to
4406b98
Compare
|
@bitbeckers @pheuberger tests are failing because treshold is not met. Don't think there's a lot of code worth testing here but also not sure if lowering the treshold is the way to go. |
Honestly I don't have a good idea how to handle these situations. Perhaps we can figure out a good testing strategy for things like this? I agree, lowering the thresholds all the time and raising them back up just creates a tremendous amount of noise. Alternatively if we think this cannot be reasonably tested, we could ignore these files on coverage tests. |
this. And the refactored API has better testability so we should view these solutions as temporary |
|
Check, added the cron jobs to the ignore list for coverage calculation 👍 |
it no longer makes sense to keep the error codes in the marketplace sdk as the only place they will be used is here.
|
@bitbeckers I think it would be best to wait for the api refactor to be merged, to add the tests for this as we discussed. That way I can follow the patterns and you mentioned it will have improved testability. Do you agree? And if so, do we want to postpone merging this until the tests are added, or create a new issue for adding tests and merge it already? |
Adds a cronjob that validates orders.