Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Establish utils to denominate all currencies against ETH/USD #26

Open
Tracked by #157
bitbeckers opened this issue Aug 5, 2024 · 1 comment
Open
Tracked by #157

Establish utils to denominate all currencies against ETH/USD #26

bitbeckers opened this issue Aug 5, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@bitbeckers
Copy link
Collaborator

bitbeckers commented Aug 5, 2024 •
edited
Loading

This is nice to add to the SDK to save other devs messing around with currencies, decimal values and hypercert units

Deals can be denominated in USD (USDC/DAI) or ETH (ETH/wETH) and we should provide utilities for easy conversion:

  • getPricesForListingInUSD
  • getPricesForListingInETH
  • getCurrencyDetails (address, decimals, symbol, name, pricefeed)

Add these utilities to the (marketplace) SDK.
@bitbeckers bitbeckers mentioned this issue Aug 5, 2024
Closed
4 tasks
@bitbeckers bitbeckers added the enhancement New feature or request label Aug 5, 2024
@bitbeckers
Copy link
Collaborator Author

Iirc these methods are in the API and maybe the app. They should be migrated to and exposed by the SDK. Based on the connected chain, query the appropriate chainlink price feed and return the outcome

@bitbeckers bitbeckers transferred this issue from hypercerts-org/hypercerts-app Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Hypercerts dev team daily ops
Status: Ready
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bitbeckers