Adapt other components to support php8. (#3673)

Author: limingxinleo

src/Concerns/FormatsMessages.php

@@ -97,7 +97,7 @@ public function getDisplayableValue(string $attribute, $value)
             return $line;
         }
 
-        return $value;
+        return (string) $value;
     }
 
     /**
@@ -291,7 +291,7 @@ protected function replaceInputPlaceholder(string $message, string $attribute):
         $actualValue = $this->getValue($attribute);
 
         if (is_scalar($actualValue) || is_null($actualValue)) {
-            $message = str_replace(':input', $actualValue, $message);
+            $message = str_replace(':input', $this->getDisplayableValue($attribute, $actualValue), $message);
         }
 
         return $message;

src/Concerns/ReplacesAttributes.php

@@ -164,7 +164,7 @@ protected function replaceGt(string $message, string $attribute, string $rule, a
             return str_replace(':value', $parameters[0], $message);
         }
 
-        return str_replace(':value', $this->getSize($attribute, $value), $message);
+        return str_replace(':value', (string) $this->getSize($attribute, $value), $message);
     }
 
     /**
@@ -176,7 +176,7 @@ protected function replaceLt(string $message, string $attribute, string $rule, a
             return str_replace(':value', $parameters[0], $message);
         }
 
-        return str_replace(':value', $this->getSize($attribute, $value), $message);
+        return str_replace(':value', (string) $this->getSize($attribute, $value), $message);
     }
 
     /**
@@ -188,7 +188,7 @@ protected function replaceGte(string $message, string $attribute, string $rule,
             return str_replace(':value', $parameters[0], $message);
         }
 
-        return str_replace(':value', $this->getSize($attribute, $value), $message);
+        return str_replace(':value', (string) $this->getSize($attribute, $value), $message);
     }
 
     /**
@@ -200,7 +200,7 @@ protected function replaceLte(string $message, string $attribute, string $rule,
             return str_replace(':value', $parameters[0], $message);
         }
 
-        return str_replace(':value', $this->getSize($attribute, $value), $message);
+        return str_replace(':value', (string) $this->getSize($attribute, $value), $message);
     }
 
     /**

src/Concerns/ValidatesAttributes.php

@@ -1476,7 +1476,7 @@ protected function allFailingRequired(array $attributes): bool
      * Get the size of an attribute.
      *
      * @param mixed $value
-     * @return mixed
+     * @return float|int
      */
     protected function getSize(string $attribute, $value)
     {

src/Rules/In.php

@@ -41,7 +41,7 @@ public function __construct(array $values)
     public function __toString(): string
     {
         $values = array_map(function ($value) {
-            return '"' . str_replace('"', '""', $value) . '"';
+            return '"' . str_replace('"', '""', (string) $value) . '"';
         }, $this->values);
 
         return $this->rule . ':' . implode(',', $values);

src/Rules/NotIn.php

@@ -39,7 +39,7 @@ public function __construct(array $values)
     public function __toString(): string
     {
         $values = array_map(function ($value) {
-            return '"' . str_replace('"', '""', $value) . '"';
+            return '"' . str_replace('"', '""', (string) $value) . '"';
         }, $this->values);
 
         return $this->rule . ':' . implode(',', $values);

tests/Cases/ValidationValidatorTest.php

@@ -4599,6 +4599,27 @@ public function testValidateAfter()
         $this->assertTrue($v->passes());
     }
 
+    public function testInputIsReplacedByItsDisplayableValue()
+    {
+        $frameworks = [
+            1 => 'Laravel',
+            2 => 'Symfony',
+            3 => 'Rails',
+        ];
+
+        $trans = $this->getIlluminateArrayTranslator();
+        $trans->addLines(['validation.framework_php' => ':input is not a valid PHP Framework'], 'en');
+
+        $v = new Validator($trans, ['framework' => 3], ['framework' => 'framework_php']);
+        $v->addExtension('framework_php', function ($attribute, $value, $parameters, $validator) {
+            return in_array($value, [1, 2]);
+        });
+        $v->addCustomValues(['framework' => $frameworks]);
+
+        $this->assertFalse($v->passes());
+        $this->assertSame('Rails is not a valid PHP Framework', $v->messages()->first('framework'));
+    }
+
     public function getIlluminateArrayTranslator()
     {
         return new Translator(