ci: install irohad with features
#5354
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shunkichi Sato <[email protected]>
s8sato
requested review from
0x009922,
DCNick3,
dima74,
mversic and
outoftardis
as code owners
0x009922
reviewed
Mar 17, 2025
Contributor
0x009922
left a comment
0x009922
left a comment
There was a problem hiding this comment.
I think it isn't really necessary to compile irohad twice. It's fine to compile once with all features.
s8sato
commented
Mar 17, 2025
s8sato
commented
Mar 21, 2025
| mv ${{ env.WASM_TARGET_DIR }}/libs ${{ env.DEFAULTS_DIR }}/libs | ||
| mv ${{ env.DEFAULTS_DIR }}/libs/default_executor.wasm ${{ env.DEFAULTS_DIR }}/executor.wasm | ||
| - name: Install irohad | ||
| run: which irohad || cargo install --path crates/irohad --locked |
Contributor
Author
There was a problem hiding this comment.
By the way, what is the possible cases that irohad is found by which command here @0x009922 ?
Contributor
There was a problem hiding this comment.
As far as I remember, it was about caching and the possibility that irohad is already available. Though I don't understand how that could be possible.
4 tasks
Contributor
Author
|
Closed as not planned, in accordance with #5355 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites for testing the
predictionfeature in #5355.