Improve performance of LayeredKeyValueStorage.get method#8563
Merged
ahamlat merged 2 commits intobesu-eth:mainfrom Apr 18, 2025
Merged
Improve performance of LayeredKeyValueStorage.get method#8563ahamlat merged 2 commits intobesu-eth:mainfrom
ahamlat merged 2 commits intobesu-eth:mainfrom
Conversation
Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
garyschulte
approved these changes
Apr 17, 2025
Contributor
garyschulte
left a comment
There was a problem hiding this comment.
Great fix. I never really liked the string comparison, but wasn't aware of the performance implications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
When profiling big blocks on a devnet where besu is sync'ing with lock step, I noticed in the profiling that using Bytes.toHexString for comparaison is hurting the performances because of the usage of megamorphic calls in this method, like get method on Bytes implementations. The pink part of the profiling below corresponds to the cost of the get megamorphic call
This PR changes the way keys are compared by working on the underlying arrays and use Arrays.compare to do the comparaison. We can see below the new profiling following this optimization.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests