Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate genesis instructions #4743

Open
mversic opened this issue Jun 19, 2024 · 1 comment · Fixed by #4757
Open

Validate genesis instructions #4743

mversic opened this issue Jun 19, 2024 · 1 comment · Fixed by #4757
Assignees
@dima74
Labels
Bug Something isn't working

Comments

@mversic
Copy link
Contributor

mversic commented Jun 19, 2024 •
edited by dima74
Loading

A thing that I have noticed. We don't validate genesis instructions at all anymore because there is no initial executor. This is a bug, only the 1st instruction (which is upgrade) should not be validated, all others should

Originally posted by @mversic in #4739 (comment)
@mversic mversic added the Bug Something isn't working label Jun 19, 2024
This was referenced Jun 19, 2024
Merged
Merged
@mversic
Copy link
Contributor Author

mversic commented Jun 19, 2024

this can most easily be solved by enforcing genesis to have 2 transactions instead of 1 where 1st is Upgrade<Executor> and 2nd contains all other instructions

@dima74 dima74 self-assigned this Jun 20, 2024
@dima74 dima74 mentioned this issue Jun 21, 2024
Merged
5 tasks
@dima74 dima74 reopened this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dima74 dima74

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: Upgrade executor in separate transaction in genesis block dima74/iroha
2 participants
@dima74 @mversic