Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename type_ to type in schema.json #4770

Open
mversic opened this issue Jun 25, 2024 · 1 comment
Open

Rename type_ to type in schema.json #4770

mversic opened this issue Jun 25, 2024 · 1 comment

Comments

@mversic
Copy link
Contributor

mversic commented Jun 25, 2024 

          `type` being a reserved Rust token should not affect the schema. If it is still `type_` internally, consider patching `IntoSchema` to support something like `rename` attribute.

Originally posted by @0x009922 in #4741 (comment)
@mversic mversic mentioned this issue Jun 25, 2024
Merged
5 tasks
@mversic
Copy link
Contributor Author

mversic commented Jun 25, 2024

also consider renaming getter function Asset::type_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mversic