Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output codeshift init to ensure ts + build process is correct. #147

Closed
danieldelcore opened this issue Feb 16, 2023 · 1 comment
Closed
Assignees
Labels
🪲 bug Something isn't working 🔥 priority High priority bugs/issues

Comments

@danieldelcore
Copy link
Contributor

danieldelcore commented Feb 16, 2023

Currently, the scaffolded project works since it's pointing directly to codeshift.config. However, it in turn points to source files not the dist files which makes the dist and the build redundant.

We want to point to dist files by default because it allows us to customise transpilation. See: #146

Considerations:

  • We will need to move the codeshift.config.js into the dist folder as well and ensure that it is pointing to built transforms
  • Test local development and built dist

image

The expected file tree should be:

-  codeshift.config.js
/dist
+  codeshift.config.js
   /1.0.0/...
/codemods
+   codeshift.config.js
   /1.0.0/...

Note: It looks like the package.json entry-point is already expecting this.

image

@danieldelcore danieldelcore added 🪲 bug Something isn't working 📈 enhancement New feature or request labels Feb 16, 2023
@danieldelcore danieldelcore self-assigned this Feb 16, 2023
@danieldelcore danieldelcore added 🔥 priority High priority bugs/issues and removed 📈 enhancement New feature or request labels Feb 16, 2023
@danieldelcore
Copy link
Contributor Author

Should be fixed in the latest version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working 🔥 priority High priority bugs/issues
Projects
None yet
Development

No branches or pull requests

1 participant