Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using HyperSpec when loading a page via visit #398

Open
catmando opened this issue Mar 31, 2021 · 1 comment
Open

Using HyperSpec when loading a page via visit #398

catmando opened this issue Mar 31, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@catmando
Copy link
Contributor

If you visit a page (rather than use mount) you don't get the HyperSpec extra stuff (like TimeCop integration, ability to use before_mount, insert_html etc.

Furthermore, when you call on_client the @hyper_spec_mounted flag is not set, and so the page will get reloaded.

You can work around the second part by doing a page.instance_variable_set("@hyper_spec_mounted", true) after the visit.

But this should all be nicely integrated, possibly some ERB helpers that could be used in test mode when loading the layout?
@catmando catmando added enhancement New feature or request needs doc Everything is working, but documentation is needed. labels Mar 31, 2021
@catmando
Copy link
Contributor Author

Doc has been updated.

@catmando catmando removed the needs doc Everything is working, but documentation is needed. label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@catmando