From 3c28bf22b30eee8ef34468657b6859c60e21f5da Mon Sep 17 00:00:00 2001
From: Kishan Sairam Adapa <kishan.adapa@traceable.ai>
Date: Mon, 29 Jul 2024 20:24:07 +0530
Subject: [PATCH] move trailing space checks to helm template based

I don't know why I went with so very complex implementation before and hadn't thought of this :)

The prev impl didn't catch the cases were helm rendering was causing issues. This should catch all
---
 validate-charts/action.yml | 27 +++++++--------------------
 1 file changed, 7 insertions(+), 20 deletions(-)

diff --git a/validate-charts/action.yml b/validate-charts/action.yml
index 5e9a033..87e84f3 100644
--- a/validate-charts/action.yml
+++ b/validate-charts/action.yml
@@ -12,32 +12,19 @@ inputs:
 runs:
   using: "composite"
   steps:
-    - name: validate helm chart
+    - name: Validate Helm Chart
       shell: bash
       run: |
         helm version
         helm dependency update ${{ inputs.chart-path }}
         helm lint ${{ inputs.chart-path }} ${{ inputs.extra-args }}
         helm template ${{ inputs.chart-path }} ${{ inputs.extra-args }}
-    - name: ensure no trailing spaces in config maps
+        
+    - name: Ensure no Trailing Spaces
       shell: bash
       run: |
-        configmaps=($(find ${{ inputs.chart-path }} -type f -regex '.*\.ya*ml' -exec grep -l "kind: ConfigMap" {} \;))
-        COUNTER=0
-        echo "Checking these config maps for trailing spaces..."
-        for yaml in "${configmaps[@]}"
-        do
-          echo $yaml
-          # we have to use sed for performing exists check because of complications dealing with grep exit code in non match
-          exists=$(sed -nE '/\S\s+$/p' $yaml)
-          [ ! -z "$exists" ] && grep -nE '\S\s+$' $yaml && COUNTER=$((COUNTER+1))
-        done
-        test $COUNTER -gt 0 && echo "$COUNTER config map yamls contain trailing spaces, please remove them"
-
-        echo "Checking values.yaml for trailing spaces..."
-        # we have to use sed for performing exists check because of complications dealing with grep exit code in non match
-        exists=$(sed -nE '/\S\s+$/p' ${{ inputs.chart-path }}/values.yaml)
-        [ ! -z "$exists" ] && grep -nE '\S\s+$' ${{ inputs.chart-path }}/values.yaml && echo "^^^^^^ values.yaml has trailing spaces, please remove them" && exit 1
-        if (( $COUNTER > 0 )); then
-          exit 1
+        output=$(helm template ${{ inputs.chart-path }} ${{ inputs.extra-args }} | sed -nE '/\S\s+$/p')
+        if [ ! -z "$output" ]; then
+          echo "trailing spaces exist in helm chart after rending at below places, please fix:"
+          echo $output
         fi