Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Model is missing businessType constants #129

Open
tgraupne opened this issue Aug 9, 2023 · 0 comments
Open

User Model is missing businessType constants #129

tgraupne opened this issue Aug 9, 2023 · 0 comments

Comments

@tgraupne
Copy link

tgraupne commented Aug 9, 2023

Hello 🙂

while I was trying to implement a matching algorithm between Hyperwallet businessType values and organization types in German Law, I found that the User model is missing some businessType constants.

According to the API v4 documentation here: https://docs.hyperwallet.com/content/api/v4/resources/users/retrieve
A User of profileType = BUSINESS can have the following businessTypes:

  • CORPORATION
  • PRIVATE_COMPANY
  • PARTNERSHIP
  • NOT_FOR_PROFIT_ORGANIZATION
  • GOVERNMENT_ENTITY
  • PUBLIC_COMPANY

However, inside the User.php file, the only available constants are:
https://github.com/hyperwallet/php-sdk/blob/master/src/Hyperwallet/Model/User.php#L80

const BUSINESS_TYPE_CORPORATION = 'CORPORATION';
const BUSINESS_TYPE_PARTNERSHIP = 'PARTNERSHIP';

Am I missing something or shouldn't there be constants for the other businessTypes as well?

As another reference to a typed implementation of the sdk:

The java-sdk does have more constants:
https://github.com/hyperwallet/java-sdk/blob/master/src/main/java/com/hyperwallet/clientsdk/model/HyperwalletUser.java#L21

However, I am not sure if it is the best reference, because it also contains the value: CANADIAN_REGISTERED_CHARITY which isn't part of the API documentation anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant