Use the correct way to detect the OC version in better way

* the api said that getVersion return and array.. so use indexes
* the api said that getL10N are since 6.0.0 but i dont trust in stupid oc api
* property set version detection and use available API for older oc
* now lest see test integration in jenkis for good results

Author: mckaygerhard

Diff for: roundcube/src/main/php/adminSettings.php

@@ -31,14 +31,14 @@
 
 
 // workaround to detect OC version
-$ocVersion = @reset(OCP\Util::getVersion());
+$ocVersion = OCP\Util::getVersion();
 // below OC7
-if ($ocVersion < 7) {
+if ($ocVersion[0] < 7) {
 	OCP\Util::addScript('roundcube', 'adminSettings.oc6');
 	$tmpl = new OCP\Template('roundcube', 'tpl.adminSettings.oc6');
 } else {
 	// OC7.x
-	if ($ocVersion < 8) {
+	if ($ocVersion[0] < 8) {
 		OCP\Util::addScript('roundcube', 'adminSettings.oc7');
 		$tmpl = new OCP\Template('roundcube', 'tpl.adminSettings.oc7');
 	} else {

Diff for: roundcube/src/main/php/ajax/adminSettings.php

@@ -11,8 +11,7 @@
 // workaround to detect OC version and compatibility for OC and nextcloud
 $ocVersion = OCP\Util::getVersion();
 
-
-if ($ocVersion < 9) {
+if ($ocVersion[0] < 9) {
 	$l = new OC_L10N('roundcube');
 } else {
 	$l = OC::$server->getL10N('roundcube');

Diff for: roundcube/src/main/php/appinfo/app.php

@@ -21,12 +21,13 @@
  */
 
 // workaround to detect OC version and compatibility for OC and nextcloud
-$ocVersion = @reset(OCP\Util::getVersion());
 
-if ($ocVersion < 9) {
+$ocVersion = implode('.',OCP\Util::getVersion());
+if (version_compare($ocVersion,'7.9.9','<')) // OC-8.0
+{
 	$l = new OC_L10N('roundcube');
 } else {
-	$l = OC::$server->getL10N('roundcube');
+	$l = OC::$server->getL10N('roundcube'); // public api said since 6 but its not sure. so only for 8+
 }
 
 OC::$CLASSPATH['OC_Mail_NetworkingException'] = OC_App::getAppPath('roundcube') . '/lib/MailNetworkingException.class.php';

Diff for: roundcube/src/main/php/lib/RoundCubeApp.class.php

@@ -571,10 +571,10 @@ public static function getRedirectPath($pRcHost, $pRcPort, $pRcPath)
 
     public static function saveUserSettings($appName, $ocUser, $rcUser, $rcPassword)
     {
-        if ($ocVersion < 9) {
+        if ($ocVersion[0] < 9) {
             $l = new OC_L10N('roundcube');
         } else {
-            $l = OC::$server->getL10N('roundcube');
+            $l = OC::$server->getL10N('roundcube'); // public api said since 6.0 but i'm not sure due oc developer are a liar
         }
 
         if (isset($appName) && $appName == "roundcube") {