Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fingering data #5

Open
Aduffy opened this issue Dec 2, 2020 · 4 comments
Open

fingering data #5

Aduffy opened this issue Dec 2, 2020 · 4 comments

Comments

@Aduffy
Copy link

Aduffy commented Dec 2, 2020

I came across this project looking for a chord database. This in many ways looks to be a better option, but does lack in fingering suggestions. Have you done any work/research for being able to add fingering suggestions?

@hyvyys
Copy link
Owner

hyvyys commented Dec 2, 2020

Hi! Looking at your activity, am I right assuming you mean "better option" than chords-db?

How would you improve the fingering suggestions? Currently these are generated programmatically. It could be possible to allow more parameters that would influence the sorting order of the results (currently I'm sorting them in an opinionated and complex way based on a few factors).

@Aduffy
Copy link
Author

Aduffy commented Dec 2, 2020

Ya collections such as chord-db seem to have quite a few errors and omissions, so a programmatic approach would seem to be a better base... Unless I completely missed something your code just provides the fret on each of the 6 strings, but not a suggestion on what finger (1-4) the player should use to play that note . For example

image

is drawn with this code using SVGuitar

{
	title: "Gmaj",
	root:"G",
	fingers: [
		[5, 5, '3'],
		[4, 5, '4'],
		[3, 4, '2']
	],
	barres: [
		{ fromString: 6, toString: 1, fret: 3, text: '1', },
	]
}

Its the "Play the bar with your first finger across the 3rd fret, then the G on filth string fret 5 with your third finger.... " part that I was seeking to be able to get..

I would imagine that suggestions for easiest ways to actually play the chord would be beyond a programmatic approach, and would need some level of human review at the very least..

@hyvyys
Copy link
Owner

hyvyys commented Dec 2, 2020

Ah, correct. I guess the name of this project is a misnomer then! A name like "chord-frettings" would be more descriptive... 😏

I never thought of implementing this because I didn't realize this was in demand. Actual fingering in my world is only useful for absolute beginners. But maybe I will think on it sometime.

@Aduffy
Copy link
Author

Aduffy commented Dec 2, 2020

Ya im looking to build a tool for teachers to be able to quickly build sets of chords for students (screen / pdf) So some use case would be absolute beginners. How playable are the chords generated? I see you have a difficulty rating in there.. nice.. but does it ever create a chord that is just not realistic for 99% of players?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants