-
Notifications
You must be signed in to change notification settings - Fork 67
variations should have language attributes #348
Comments
Language can be set on variations by running:
vp is the variation post, p is the parent post, joined to the language taxonomy via the term_relationships table. if you want to check your data before running try eg:
how many variations actually are assigned to each language: you could run this before and after to test and confirm effect of insert
Notes:
The SQL is fine, more testing needed to see if there is any negative impact from adding the language reference.
|
Fixed in the code for any future saves of variations, |
Can you reproduce this issue on default Wordpress theme (eg Storefront)?
yes
Can you reproduce this issue when all other plugins are disabled except WooCommerce, Polylang and Hyyan WooCommerce Polylang Integration?
yes
What product versions and settings are you using when this issue occurs?
Steps to Reproduce
What I Expected
product variations should be included if passed in the args
What Happened Instead
product variations are not included.
This is because product variations do not have a language assigned, but Polylang adds the language filter, so they become excluded.
@hyyan why are the variations linked by '_point_to_variation' rather than using the native Polylang functions to link up the variations? - in which case variations would be compatible with the rest of Polylang and need less special handling?
The text was updated successfully, but these errors were encountered: